Type hints, 3.6 ZIP error and better file handling #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add a proxy `_fd` property that will raise a ValueError if the file is closed. This gives a better error message than an AttributeError - allow calling `close()` more than once - add `closed` property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were already a few type hints in the code so here's the rest. While testing that on 3.6 I found that in this version
seek()was not added yet toZipExtFileso you'd get anio.UnsupportedOperation: seekerror when using pakler with a ZIP file which isn't very helpful. Exiting with a nicer error message is more meaningful to the user. Last change was mostly to get rid of the type checker errors after adding the type hints, but it will also show a nicer error message if there is an attempt to use the file after it's been closed. Allowingclose()to be called more than once and theclosedproperty bring the functionality closer to file-related objects of the standard library likeio.IOBase.