Php84 Support #116
Open
Php84 Support #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameters with a default of null must be nullable is a new depreciation in PHP 8.4. Nullable parameters were introduced in PHP 7.1.
So this PR adds nullable parameter for the bool $force in the toggle method and the replaceTextWithCallback \DOMNode $domNode parameter.
I also dropped support for PHP 7.0, as it is very old and Packagist shows a monthly usage of only 0.2%.
I also updated the CI pipeline to test all versions of PHP and updated PHPUnit to 11 if needed by the PHP version.
This change is