Skip to content

fix: update observer test to use /models endpoint instead of non-exis…#1407

Merged
qin-ctx merged 1 commit into
volcengine:mainfrom
kaisongli:fix/observer-vlm-test-404
Apr 14, 2026
Merged

fix: update observer test to use /models endpoint instead of non-exis…#1407
qin-ctx merged 1 commit into
volcengine:mainfrom
kaisongli:fix/observer-vlm-test-404

Conversation

@kaisongli
Copy link
Copy Markdown
Collaborator

…tent /vlm

The /api/v1/observer/vlm endpoint does not exist in the server router. The correct endpoint for VLM status is /api/v1/observer/models which returns status for VLM, Embedding, and Rerank models.

Changes:

  • client.py: rename observer_vlm() to observer_models(), update endpoint
  • test_observer.py: rename test_observer_vlm to test_observer_models
  • test_api_observer.py: rename test_observer_vlm to test_observer_models

Description

Related Issue

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Changes Made

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this on the following platforms:
    • Linux
    • macOS
    • Windows

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes

@github-actions
Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🏅 Score: 100
🧪 PR contains tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@github-actions
Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

…tent /vlm

The /api/v1/observer/vlm endpoint does not exist in the server router.
The correct endpoint for VLM status is /api/v1/observer/models which
returns status for VLM, Embedding, and Rerank models.

Changes:
- client.py: rename observer_vlm() to observer_models(), update endpoint
- test_observer.py: rename test_observer_vlm to test_observer_models
- test_api_observer.py: rename test_observer_vlm to test_observer_models
@kaisongli kaisongli force-pushed the fix/observer-vlm-test-404 branch from bf03ef5 to 882f8b3 Compare April 13, 2026 07:29
@qin-ctx qin-ctx merged commit d941b80 into volcengine:main Apr 14, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in OpenViking project Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants