fix parameter description#512
Open
AndreasPfaffeneder wants to merge 2 commits intovoxpupuli:masterfrom
Open
Conversation
alexjfisher
reviewed
Jun 14, 2021
| # one processor on receipt of the token. The max_messages parameter is limited | ||
| # to 256000 / netmtu to prevent overflow of the kernel transmit buffers. | ||
| # | ||
| # @param test_corosync_config |
Member
There was a problem hiding this comment.
test_corosync_config is still a parameter though, so doesn't it also need documenting?
Member
There was a problem hiding this comment.
Did you mean to remove the documentation for test_corosync_config_cmd instead?
(Also, do you want to check the email address you use for your commits so that it links to your github user?)
Contributor
Author
There was a problem hiding this comment.
excuse me, you are right
Member
|
@AndreasPfaffeneder can you take a look at the used email address in the commits? the used address is not associated with your github account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This comment corrects the description for the newly introduced parameter param config_validate_cmd which was introduced with #508
This Pull Request (PR) fixes the following issues
Fixes a incorrect descrption of the parameter