Module forces iteration in $version and $pkg_version on Linux

• Module version: 5.2, 5.3 and current master
• Puppet version: 4.7.0
• OS and version: CentOS Linux release 7.2.1511 (Core)

Bug description

Usecase

I'm building a elk stack logging cluster where the elasticsearch version is pinned to version 5.4.0.
Pinning this version made me discover a bug in the module.
In the file manifests/init.pp (rule 590 in master) there is an if statement that forces package versions to use iterations on Linux.

  if ($version != false) {
    case $::osfamily {
      'RedHat', 'Linux', 'Suse': {
        if ($version =~ /.+-\d/) {
          $pkg_version = $version
        } else {
          $pkg_version = "${version}-1"
        }
      }
      default: {
        $pkg_version = $version
      }
    }
  }

The problem is that Elastic is not using iterations in their packages.

Error during puppet run

Error: Could not update: Execution of '/bin/yum -d 0 -e 0 -y install elasticsearch-5.4.0-1' returned 1: Error: Nothing to do
Error: /Stage[main]/Elasticsearch::Package/Package[elasticsearch]/ensure: change from purged to 5.4.0-1 failed: Could not update: Execution of '/bin/yum -d 0 -e 0 -y install elasticsearch-5.4.0-1' returned 1: Error: Nothing to do

Puppet profile

  $katellorepositoryserver = hiera('katellorepositoryserver'),
  $esversion               = hiera('esversion','5.4.0'),  #Is empty in hieradata
  $esclusterrole           = hiera('esclusterrole','logcentral'),
  $esnodes                 = hiera_array('esnodes', ['127.0.0.1:9300']),
  $esconfighiera           = hiera_hash('elasticsearch_config', {}),
  $eslicense               = hiera('elasticsearch_license', undef),
){

  profile::linux::repos::yumrepo{ 'elastic':
    descr    => 'elastic-5.x',
    baseurl  => "http://${katellorepositoryserver}/pulp/repos/Default_Organization/${::env}/elastic-5_x/custom/Elastic/elastic-5_x",
    enabled  => 1,
    gpgcheck => 0,
  }

  #ES_HEAP_SIZE = 50% of memorysize
  $esheapsize=abs($::memorysize_mb/2)

  $esconfig_defaults   = {
    'ES_HEAP_SIZE'                         => $esheapsize,
    'path.logs'                            => '/var/log/elasticsearch',
    'cluster.name'                         => "${esclusterrole}-${::env}",
    'transport.host'                       => $::networking['interfaces'][$svc_interface]['ip'],
    'discovery.zen.ping.multicast.enabled' => false,
    'discovery.zen.ping.unicast.hosts'     => join($esnodes, ','),
    'discovery.zen.minimum_master_nodes'   => '2',
    'node.name'                            => $::hostname,
    'node.master'                          => true,
    'node.data'                            => false,
    'node.ingest'                          => false,
  }

  # 2nd hash has prio over 1st hash
  $esconfig = deep_merge($esconfig_defaults, $esconfighiera)

  class { '::elasticsearch':
    manage_repo  => false,
    java_install => true,
    autoupgrade  => false,
    version      => $esversion,
    config       => $esconfig,
    #datadir      => $datadir,
    require      => Yumrepo['elastic'],
  }
}

Could you please fix the if statement that forces the iteration? Since you do not use iterations.

[tylerjl]

Hi @wonderfulwb,

The upstream elasticsearch repo is actually still using iterations/package revisions:

[root@c25b1402478a /]# yum --showduplicates list elasticsearch
Loaded plugins: fastestmirror, ovl
Loading mirror speeds from cached hostfile
 * base: mirror.netdepot.com
 * extras: repos.mia.quadranet.com
 * updates: mirrors.lga7.us.voxel.net
Available Packages
elasticsearch.noarch                                        5.0.0-1                                         elasticsearch-5.x
elasticsearch.noarch                                        5.0.1-1                                         elasticsearch-5.x
elasticsearch.noarch                                        5.0.2-1                                         elasticsearch-5.x
elasticsearch.noarch                                        5.1.1-1                                         elasticsearch-5.x
elasticsearch.noarch                                        5.1.2-1                                         elasticsearch-5.x
elasticsearch.noarch                                        5.2.0-1                                         elasticsearch-5.x
elasticsearch.noarch                                        5.2.1-1                                         elasticsearch-5.x
elasticsearch.noarch                                        5.2.2-1                                         elasticsearch-5.x
elasticsearch.noarch                                        5.3.0-1                                         elasticsearch-5.x
elasticsearch.noarch                                        5.3.1-1                                         elasticsearch-5.x
elasticsearch.noarch                                        5.3.2-1                                         elasticsearch-5.x
elasticsearch.noarch                                        5.3.3-1                                         elasticsearch-5.x
elasticsearch.noarch                                        5.4.0-1                                         elasticsearch-5.x
elasticsearch.noarch                                        5.4.1-1                                         elasticsearch-5.x

And I've confirmed the following manifest works as expected.

class { 'elasticsearch':
        java_install => true,
        manage_repo => true,
        version => '5.4.0',
        repo_version => '5.x',
}

Are you sure you're not changing the package metadata when managing your custom repository?

Hi @tylerjl ,
I do not suspect that our Katello changes package metadata. Although we can not ensure this.
But I strongly suspect that if the module stops forcing the combination of the version and the iteration/release it will use the version specified in the filename that Elastic uses (https://www.elastic.co/downloads/elasticsearch) and it would work with a not ES managed repo and it will keep all the variables apart.

# yum info elasticsearch
Loaded plugins: fastestmirror, versionlock
Loading mirror speeds from cached hostfile
Installed Packages
Name        : elasticsearch
Arch        : noarch
Version     : 5.4.0
Release     : 1
Size        : 35 M
Repo        : installed
From repo   : elastic
Summary     : Elasticsearch is a distributed RESTful search engine built for the cloud. Reference documentation can be found at
            : https://www.elastic.co/guide/en/elasticsearch/reference/current/index.html and the 'Elasticsearch: The Definitive Guide' book can be found at
            : https://www.elastic.co/guide/en/elasticsearch/guide/current/index.html
URL         : https://www.elastic.co/
License     : 2009
Description : Elasticsearch subproject :distribution:rpm

[tylerjl]

Although the Elastic repositories definitely implement a package release, this does seem like it could be improved for users on custom repositories/that know exactly what package version to use. I've pushed a branch to my fork that should address this, I'll watch to see if anything breaks badly in CI.