-
-
Notifications
You must be signed in to change notification settings - Fork 449
Replset with gha and modulesync #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.sync.yml
Outdated
beaker_facter: 'mongodb_repo_version:MongoDB:4.4,5.0,6.0,7.0' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before we merge this, please fix the broken newline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to fix it in #743 and will close this PR without merge when I'm done with all the gha changes.
uses: StatensPensjonskasse/gha-puppet/.github/workflows/beaker.yml@add-metadata2gha-option-beaker-hosts | ||
with: | ||
pidfile_workaround: 'false' | ||
beaker_hosts: 'host1:shard.ma;host2:slave,router.a' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you raise another PR where beaker_hosts isn't set so we can ensure the change in gha-puppet doens't break existing setups?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All green here now. I'll just do another force push here and remove beaker_hosts to test that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, thanks for having me test that. Ends up with env var BEAKER_SETFILE empty .....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working testrun without beaker_hosts https://github.com/voxpupuli/puppet-mongodb/actions/runs/8834718677
I'm going to add beaker_hosts again to verify that with puppet_metadata 3.7.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testrun with beaker_hosts set https://github.com/voxpupuli/puppet-mongodb/actions/runs/8835013808
Closing this now that #743 is updated and ready to be merged |
Just testing if my updates to puppet_metadata and gha-puppet is working
Branch is based on StatensPensjonskasse:fix-replset-acceptance-testing #743