fix: replace legacy facst in providers

also add acceptance tests for network_route which should catch something
like this in the future

Refs: #348

Author: TheMeier

.sync.yml

@@ -7,3 +7,5 @@ Gemfile:
     ':test':
       - gem: 'ipaddress'
       - gem: 'rspec-its'
+spec/spec_helper_acceptance.rb:
+  unmanaged: false

lib/puppet/provider/network_config/interfaces.rb

@@ -13,8 +13,8 @@
 
   desc 'Debian interfaces style provider'
 
-  confine osfamily: :debian
-  defaultfor osfamily: :debian
+  confine 'os.family' => :debian
+  defaultfor 'os.family' => :debian
 
   has_feature :provider_options
   has_feature :hotpluggable

lib/puppet/provider/network_config/redhat.rb

@@ -12,8 +12,8 @@
 
   desc 'Redhat network-scripts provider'
 
-  confine osfamily: :redhat
-  defaultfor osfamily: :redhat
+  confine 'os.family' => :redhat
+  defaultfor 'os.family' => :redhat
 
   has_feature :hotpluggable
   has_feature :provider_options

lib/puppet/provider/network_config/sles.rb

@@ -12,8 +12,8 @@
 
   desc 'SLES network-scripts provider'
 
-  confine osfamily: :suse
-  defaultfor osfamily: :suse
+  confine 'os.family' => :suse
+  defaultfor 'os.family' => :suse
 
   has_feature :startmode
   has_feature :provider_options

lib/puppet/provider/network_route/redhat.rb

@@ -13,8 +13,8 @@
 
   desc 'RHEL style routes provider'
 
-  confine osfamily: :redhat
-  defaultfor osfamily: :redhat
+  confine 'os.family' => :redhat
+  defaultfor 'os.family' => :redhat
 
   has_feature :provider_options
 

lib/puppet/provider/network_route/routes.rb

@@ -14,13 +14,13 @@
 
   desc 'Debian routes style provider'
 
-  confine osfamily: :debian
+  confine 'os.family' => :debian
 
   # $ dpkg -S /etc/network/if-up.d/20static-routes
   # ifupdown-extra: /etc/network/if-up.d/20static-routes
   confine exists: '/etc/network/if-up.d/20static-routes'
 
-  defaultfor osfamily: :debian
+  defaultfor 'os.family' => :debian
 
   has_feature :provider_options
 

lib/puppet/provider/network_route/sles.rb

@@ -13,8 +13,8 @@
 
   desc 'SLES style routes provider'
 
-  confine osfamily: :suse
-  defaultfor osfamily: :suse
+  confine 'os.family' => :suse
+  defaultfor 'os.family' => :suse
 
   has_feature :provider_options
 

spec/acceptance/network_route_spec.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+require 'spec_helper_acceptance'
+
+describe 'network_route' do
+  it 'is able to select a route provider' do
+    pp = <<-EOS
+      include network
+      network_route { '127.0.0.2/32':
+        ensure    => 'present',
+        gateway   => '127.0.0.1',
+        interface => 'lo',
+        netmask   => '255.255.255.255',
+      }
+    EOS
+    # Run it twice and test for idempotency
+    apply_manifest(pp, catch_failures: true)
+  end
+end

spec/spec_helper_acceptance.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+# Managed by modulesync - DO NOT EDIT
+# https://voxpupuli.org/docs/updating-files-managed-with-modulesync/
+
+require 'voxpupuli/acceptance/spec_helper_acceptance'
+
+configure_beaker(modules: :metadata)
+
+Dir['./spec/support/acceptance/**/*.rb'].sort.each { |f| require f }