add nginx::proxy_bind#1427
Open
raemer wants to merge 2 commits into
Open
Conversation
nginx::config is a classBreaking changes to this file MAY impact these 2 modules (near match):nginx is a classBreaking changes to this file WILL impact these 13 modules (exact match):Breaking changes to this file MAY impact these 34 modules (near match):
This module is declared in 9 of 575 indexed public
|
bastelfreak
reviewed
Jan 22, 2021
| ], | ||
| Array $proxy_hide_header = [], | ||
| Array $proxy_pass_header = [], | ||
| Optional[String] $proxy_bind = undef, |
Member
There was a problem hiding this comment.
can you enforce the datatype a bit more? which values are valid here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR adds "proxy_bind" parameter to the nginx class. If set, it generates a config entry in nginx.conf, block "http".