Configure unix socket on ssl vhost #1463
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
added
needs-help
|
Hi! Can you add some test in your PR to ensure this new feature is not broken by future evolution/refactoring of the module? |
ymartin-ovh
force-pushed
the
ssl-unix-socket
branch
2 times, most recently
from
ad5bdef to
7103ff1
Compare
ymartin-ovh
force-pushed
the
ssl-unix-socket
branch
from
7103ff1 to
cf906f9
Compare
ymartin-ovh
force-pushed
the
ssl-unix-socket
branch
2 times, most recently
from
0124ce5 to
9a46cc4
Compare
smortex
approved these changes
Sep 28, 2021
|
Hey @ymartin-ovh , can you rebase with our master branch? That should fix failing specs. |
kenyon
force-pushed
the
ssl-unix-socket
branch
from
9a46cc4 to
0f49bc0
Compare
|
Rebased. |
ymartin-ovh
force-pushed
the
ssl-unix-socket
branch
2 times, most recently
from
5a887e5 to
351cffb
Compare
ymartin-ovh
force-pushed
the
ssl-unix-socket
branch
2 times, most recently
from
d06a097 to
9b3938b
Compare
ymartin-ovh
force-pushed
the
ssl-unix-socket
branch
from
9b3938b to
fa2003f
Compare
ymartin-ovh
force-pushed
the
ssl-unix-socket
branch
2 times, most recently
from
0d2c905 to
55270b1
Compare
ymartin-ovh
force-pushed
the
ssl-unix-socket
branch
from
55270b1 to
39815ae
Compare
|
Hello @smortex. I updated this PR to pass checks. Regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
I want to configure nginx unix socket on SSL vhost. In my case, I have listen_port == ssl_port, selected template does not allow me to configure unix socket.