Fix Spec Test

Author: Valantin

spec/classes/openvpn_config_spec.rb

@@ -2,40 +2,35 @@
 
 require 'spec_helper'
 
-describe 'openvpn::config', type: :class do
-  on_supported_os.each do |os, facts|
+describe 'openvpn::config' do
+  on_supported_os.each do |os, os_facts|
     context "on #{os}" do
       let(:facts) do
-        facts
+        os_facts.merge(
+          easyrsa: '3.0'
+        )
       end
 
+      let(:pre_condition) { 'include openvpn' } if os_facts[:os]['family'] == 'Debian'
+
       it { is_expected.to compile.with_all_deps }
 
-      case facts[:os]['family']
+      case os_facts[:os]['family']
       when 'Debian'
-        context 'on Debian based machines' do
-          it { is_expected.to contain_concat('/etc/default/openvpn') }
-          it { is_expected.to contain_concat__fragment('openvpn.default.header') }
-
-          context 'enabled autostart_all' do
-            let(:pre_condition) { 'class { "openvpn": autostart_all => true }' }
-
-            it {
-              is_expected.to contain_concat__fragment('openvpn.default.header').with(
-                'content' => %r{^AUTOSTART="all"}
-              )
-            }
-          end
-
-          context 'disabled autostart_all' do
-            let(:pre_condition) { 'class { "openvpn": autostart_all => false }' }
-
-            it {
-              is_expected.to contain_concat__fragment('openvpn.default.header').with(
-                'content' => %r{^AUTOSTART=""}
-              )
-            }
-          end
+        it { is_expected.to contain_concat('/etc/default/openvpn') }
+
+        it { is_expected.to contain_concat__fragment('openvpn.default.header') }
+
+        context 'enabled autostart_all' do
+          let(:pre_condition) { 'class { "openvpn": autostart_all => true }' }
+
+          it { is_expected.to contain_concat__fragment('openvpn.default.header').with_content(%r{^AUTOSTART="all"}) }
+        end
+
+        context 'disabled autostart_all' do
+          let(:pre_condition) { 'class { "openvpn": autostart_all => false }' }
+
+          it { is_expected.to contain_concat__fragment('openvpn.default.header').with_content(%r{^AUTOSTART=""}) }
         end
       end
     end

spec/classes/openvpn_init_spec.rb

@@ -2,35 +2,30 @@
 
 require 'spec_helper'
 
-describe 'openvpn', type: :class do
-  on_supported_os.each do |os, facts|
+describe 'openvpn' do
+  on_supported_os.each do |os, os_facts|
     context "on #{os}" do
-      let(:pre_condition) { 'class { "openvpn" : manage_service => true }' }
+      let(:facts) do
+        os_facts.merge(
+          easyrsa: '3.0'
+        )
+      end
 
       it { is_expected.to compile.with_all_deps }
 
-      os_name = facts[:os]['name']
-      os_release = facts[:os]['release']['major']
-      case "#{os_name}-#{os_release}"
-      when %r{FreeBSD}
-        let(:facts) do
-          facts
-        end
+      it { is_expected.to create_class('openvpn') }
+      it { is_expected.to contain_class('openvpn::install') }
+      it { is_expected.to contain_class('openvpn::config') }
 
-        context 'system without systemd' do
+      if os_facts[:service_provider] == 'systemd'
+        context 'system with systemd' do
           it { is_expected.to create_class('openvpn') }
-          it { is_expected.to contain_class('openvpn::service') }
+          it { is_expected.not_to contain_class('openvpn::service') }
         end
       else
-        let(:facts) do
-          facts.merge(
-            service_provider: 'systemd'
-          )
-        end
-
-        context 'system with systemd' do
+        context 'system without systemd' do
           it { is_expected.to create_class('openvpn') }
-          it { is_expected.not_to contain_class('openvpn::service') }
+          it { is_expected.to contain_class('openvpn::service') }
         end
       end
     end

spec/classes/openvpn_install_spec.rb

@@ -2,36 +2,43 @@
 
 require 'spec_helper'
 
-describe 'openvpn::install', type: :class do
-  on_supported_os.each do |os, facts|
+describe 'openvpn::install' do
+  on_supported_os.each do |os, os_facts|
     context "on #{os}" do
-      let(:pre_condition) do
-        'include openvpn'
-      end
       let(:facts) do
-        facts
+        os_facts.merge(
+          easyrsa: '3.0'
+        )
       end
+      let(:pre_condition) { 'include openvpn' }
+
+      etc_directory = case os_facts[:os]['family']
+                      when 'Solaris'
+                        '/opt/local/etc'
+                      when 'FreeBSD'
+                        '/usr/local/etc'
+                      else
+                        '/etc'
+                      end
 
       it { is_expected.to compile.with_all_deps }
 
       it { is_expected.to create_class('openvpn::install') }
+
       it { is_expected.to contain_package('openvpn') }
 
-      it { is_expected.to contain_file('/etc/openvpn').with('ensure' => 'directory') }
-      it { is_expected.to contain_file('/etc/openvpn/keys').with('ensure' => 'directory') }
-      it { is_expected.to contain_file('/var/log/openvpn').with('ensure' => 'directory') }
+      it { is_expected.to contain_file("#{etc_directory}/openvpn").with_ensure('directory') }
+
+      it { is_expected.to contain_file("#{etc_directory}/openvpn/keys").with_ensure('directory') }
+
+      it { is_expected.to contain_file('/var/log/openvpn').with_ensure('directory') }
 
       it { is_expected.to contain_package('easy-rsa') }
 
-      case facts[:os]['family']
-      when 'Debian'
-        context 'debian' do
-          it { is_expected.to contain_package('openvpn-auth-ldap') }
-        end
-      when 'Archlinux'
-        context 'Archlinux' do
-          it { is_expected.not_to contain_package('openvpn-auth-ldap') }
-        end
+      if os_facts[:os]['family'] == 'Debian'
+        it { is_expected.to contain_package('openvpn-auth-ldap') }
+      else
+        it { is_expected.not_to contain_package('openvpn-auth-ldap') }
       end
     end
   end

spec/classes/openvpn_service_spec.rb

@@ -2,24 +2,56 @@
 
 require 'spec_helper'
 
-describe 'openvpn::service', type: :class do
-  on_supported_os.each do |os, facts|
+describe 'openvpn::service' do
+  on_supported_os.each do |os, os_facts|
     context "on #{os}" do
-      let(:pre_condition) { 'class { "openvpn": manage_service => true }' }
       let(:facts) do
-        facts
+        os_facts.merge(
+          easyrsa: '3.0'
+        )
       end
+      let(:pre_condition) { 'include openvpn' }
 
       it { is_expected.to compile.with_all_deps }
 
-      it { is_expected.to create_class('openvpn::service') }
+      context 'enabled manage_service and disabled namespecific_rclink' do
+        let(:pre_condition) do
+          'class { "openvpn":
+            manage_service => true,
+            namespecific_rclink => false
+          }'
+        end
 
-      it {
-        is_expected.to contain_service('openvpn').with(
-          'ensure' => 'running',
-          'enable' => true
-        )
-      }
+        it { is_expected.to create_class('openvpn::service') }
+
+        it { is_expected.to contain_service('openvpn').with_ensure('running').with_enable(true) }
+      end
+
+      context 'disabled manage_service and disabled namespecific_rclink' do
+        let(:pre_condition) do
+          'class { "openvpn":
+            manage_service => false,
+            namespecific_rclink => false
+          }'
+        end
+
+        it { is_expected.to create_class('openvpn::service') }
+
+        it { is_expected.not_to contain_service('openvpn') }
+      end
+
+      context 'disabled manage_service and enabled namespecific_rclink' do
+        let(:pre_condition) do
+          'class { "openvpn":
+            manage_service => false,
+            namespecific_rclink => true
+          }'
+        end
+
+        it { is_expected.to create_class('openvpn::service') }
+
+        it { is_expected.not_to contain_service('openvpn') }
+      end
     end
   end
 end