Skip to content

Fix CI #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
May 2, 2025
Merged

Fix CI #474

merged 33 commits into from
May 2, 2025

Conversation

Valantin
Copy link
Contributor

@Valantin Valantin commented Apr 28, 2025

Pull Request (PR) description

Fix Acceptance and rspec

This Pull Request (PR) fixes the following issues

#417

This Pull Request (PR) include the following PR

#441
#457
#458
#459
#466
#467
#468
#469
#470
#471
#472
#473

@Valantin Valantin force-pushed the fix-test branch 3 times, most recently from e10927c to 6da4585 Compare April 28, 2025 12:05
@Valantin Valantin mentioned this pull request Apr 28, 2025
@Valantin Valantin force-pushed the fix-test branch 3 times, most recently from 67cc8c7 to bf62e83 Compare April 29, 2025 09:45
@Valantin Valantin force-pushed the fix-test branch 3 times, most recently from 34f8ed6 to a1838de Compare April 29, 2025 10:44
@yakatz
Copy link
Member

yakatz commented May 1, 2025

Because the CI passes, I am comfortable merging some of the other PRs even if they don't pass. Once those are in, this can be rebased instead of including them.

Copy link
Contributor

@zilchms zilchms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with merging this as is, and therefore merging all included PRs. Tests seem fine to me. We should drop ubuntu 20.04 support before releasing the next major version.

@Valantin
Copy link
Contributor Author

Valantin commented May 2, 2025

Yes I've a Commit ready to drop ubuntu20

@Valantin Valantin merged commit aeb6ca1 into voxpupuli:master May 2, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants