-
-
Notifications
You must be signed in to change notification settings - Fork 203
Fix CI #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI #474
Conversation
e10927c
to
6da4585
Compare
67cc8c7
to
bf62e83
Compare
34f8ed6
to
a1838de
Compare
Because the CI passes, I am comfortable merging some of the other PRs even if they don't pass. Once those are in, this can be rebased instead of including them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with merging this as is, and therefore merging all included PRs. Tests seem fine to me. We should drop ubuntu 20.04 support before releasing the next major version.
Yes I've a Commit ready to drop ubuntu20 |
Pull Request (PR) description
Fix Acceptance and rspec
This Pull Request (PR) fixes the following issues
#417
This Pull Request (PR) include the following PR
#441
#457
#458
#459
#466
#467
#468
#469
#470
#471
#472
#473