Fix Test

initial refactoring of acceptance
port test to rspec-mock
remove unused erlang module from fixture
bump dependency version
user facts['service_provider] instead facts[systemd]

Author: Roberto Valentini

.fixtures.yml

@@ -3,6 +3,5 @@ fixtures:
     stdlib: 'https://github.com/puppetlabs/puppetlabs-stdlib'
     apt: 'https://github.com/puppetlabs/puppetlabs-apt'
     archive: 'https://github.com/voxpupuli/puppet-archive'
-    erlang: 'https://github.com/garethr/garethr-erlang'
     systemd: 'https://github.com/voxpupuli/puppet-systemd'
     yumrepo_core: 'https://github.com/puppetlabs/puppetlabs-yumrepo_core'

lib/facter/rabbitmq_nodename.rb

@@ -5,7 +5,7 @@
     if Facter::Util::Resolution.which('rabbitmqctl')
       rabbitmq_nodename = Facter::Core::Execution.execute('rabbitmqctl status 2>&1')
       begin
-        %r{^Status of node '?([\w.\-]+@[\w.\-]+)'?}.match(rabbitmq_nodename)[1]
+        %r{^Status of node '?([\w.-]+@[\w.-]+)'?}.match(rabbitmq_nodename)[1]
       rescue StandardError
         Facter.debug("Error: rabbitmq_nodename facter failed. Output was #{rabbitmq_nodename}")
       end

manifests/config.pp

@@ -234,7 +234,7 @@
     default: {}
   }
 
-  if $facts['systemd'] { # systemd fact provided by systemd module
+  if $facts['service_provider'] == 'systemd' { # systemd fact provided by systemd module
     systemd::service_limits { "${service_name}.service":
       selinux_ignore_defaults => ($facts['os']['family'] == 'RedHat'),
       limits                  => {

manifests/service.pp

@@ -27,7 +27,7 @@
       hasrestart => true,
       name       => $service_name,
     }
-    if $facts['systemd'] and defined(Class['systemd::systemctl::daemon_reload']) {
+    if $facts['service_provider'] == 'systemd' and defined(Class['systemd::systemctl::daemon_reload']) {
       Class['systemd::systemctl::daemon_reload'] -> Service['rabbitmq-server']
     }
   }

metadata.json

@@ -58,15 +58,15 @@
   "dependencies": [
     {
       "name": "puppetlabs/stdlib",
-      "version_requirement": ">= 4.25.0 < 9.0.0"
+      "version_requirement": ">= 4.25.0 < 10.0.0"
     },
     {
       "name": "puppet/archive",
-      "version_requirement": ">= 2.0.0 < 7.0.0"
+      "version_requirement": ">= 2.0.0 < 8.0.0"
     },
     {
       "name": "puppet/systemd",
-      "version_requirement": ">= 2.10.0 < 5.0.0"
+      "version_requirement": ">= 2.10.0 < 7.0.0"
     }
   ],
   "tags": [

spec/acceptance/binding_spec.rb

@@ -0,0 +1,117 @@
+# frozen_string_literal: true
+
+require 'spec_helper_acceptance'
+
+describe 'rabbitmq_binding:' do
+  before do
+    pp = <<-EOS
+    class { 'rabbitmq':
+      service_manage    => true,
+      port              => 5672,
+      delete_guest_user => true,
+      admin_enable      => true,
+    }
+    -> rabbitmq_user { 'dan':
+      admin    => true,
+      password => 'bar',
+      tags     => ['monitoring', 'tag1'],
+    }
+    -> rabbitmq_user_permissions { 'dan@host1':
+      configure_permission => '.*',
+      read_permission      => '.*',
+      write_permission     => '.*',
+    }
+    rabbitmq_vhost { 'host1':
+      ensure => present,
+    }
+    -> rabbitmq_exchange { 'exchange1@host1':
+      user     => 'dan',
+      password => 'bar',
+      type     => 'topic',
+      ensure   => present,
+    }
+    -> rabbitmq_queue { 'queue1@host1':
+      user        => 'dan',
+      password    => 'bar',
+      durable     => true,
+      auto_delete => false,
+      ensure      => present,
+    }
+    EOS
+
+    apply_manifest(pp, catch_failures: true)
+  end
+
+  context 'when using one routing_key' do
+    it_behaves_like 'an idempotent resource' do
+      let(:manifest) do
+        <<-PUPPET
+        rabbitmq_binding { 'exchange1@queue1@host1':
+          user             => 'dan',
+          password         => 'bar',
+          destination_type => 'queue',
+          routing_key      => '#',
+          ensure           => present,
+        }
+        PUPPET
+      end
+    end
+
+    it 'binding exist' do
+      shell('rabbitmqctl list_bindings -q -p host1') do |r|
+        expect(r.stdout).to match(%r{exchange1\sexchange\squeue1\squeue\s#})
+        expect(r.exit_code).to be_zero
+      end
+    end
+
+    it 'resource has the queue' do
+      shell('rabbitmqctl list_queues -q -p host1') do |r|
+        expect(r.stdout).to match(%r{queue1})
+        expect(r.exit_code).to be_zero
+      end
+    end
+  end
+
+  context 'when using two routing_keys' do
+    it_behaves_like 'an idempotent resource' do
+      let(:manifest) do
+        <<-PUPPET
+        rabbitmq_binding { 'binding 1':
+          source           => 'exchange1',
+          destination      => 'queue1',
+          user             => 'dan',
+          vhost            => 'host1',
+          password         => 'bar',
+          destination_type => 'queue',
+          routing_key      => 'test1',
+          ensure           => present,
+        }
+        -> rabbitmq_binding { 'binding 2':
+          source           => 'exchange1',
+          destination      => 'queue1',
+          user             => 'dan',
+          vhost            => 'host1',
+          password         => 'bar',
+          destination_type => 'queue',
+          routing_key      => 'test2',
+          ensure           => present,
+        }
+        PUPPET
+      end
+    end
+
+    it 'resource has the bindings' do
+      shell('rabbitmqctl list_bindings -q -p host1') do |r|
+        expect(r.stdout).to match(%r{exchange1\sexchange\squeue1\squeue\stest1})
+        expect(r.stdout).to match(%r{exchange1\sexchange\squeue1\squeue\stest2})
+        expect(r.exit_code).to be_zero
+      end
+    end
+
+    it 'puppet resource shows a binding' do
+      shell('puppet resource rabbitmq_binding') do |r|
+        expect(r.stdout).to match(%r{source\s+=>\s+'exchange1',})
+      end
+    end
+  end
+end