diff --git a/.fixtures.yml b/.fixtures.yml index d8e86d6ae..edf971fe0 100644 --- a/.fixtures.yml +++ b/.fixtures.yml @@ -3,6 +3,7 @@ fixtures: stdlib: 'https://github.com/puppetlabs/puppetlabs-stdlib' apt: 'https://github.com/puppetlabs/puppetlabs-apt' archive: 'https://github.com/voxpupuli/puppet-archive' - erlang: 'https://github.com/garethr/garethr-erlang' + erlang: 'https://github.com/voxpupuli/puppet-erlang' systemd: 'https://github.com/voxpupuli/puppet-systemd' + epel: 'https://github.com/voxpupuli/puppet-epel' yumrepo_core: 'https://github.com/puppetlabs/puppetlabs-yumrepo_core' diff --git a/examples/erlang_deps.pp b/examples/erlang_deps.pp index 16e566ac1..a04b658bb 100644 --- a/examples/erlang_deps.pp +++ b/examples/erlang_deps.pp @@ -1,5 +1,4 @@ -# install first the garethr-erlang module. See README.md +# install first the puppet/erlang module. See README.md include erlang -class { 'erlang': epel_enable => true } Class['erlang'] -> Class['rabbitmq'] diff --git a/manifests/init.pp b/manifests/init.pp index 2eb9164b3..942cbe1c2 100644 --- a/manifests/init.pp +++ b/manifests/init.pp @@ -492,6 +492,8 @@ } } + # when repos_ensure is true, we configure externel repos + # CentOS 7 doesn't contain rabbitmq. It's only in EPEL. if $repos_ensure { case $facts['os']['family'] { 'RedHat': { @@ -505,6 +507,8 @@ default: { } } + } elsif ($facts['os']['family'] == 'RedHat' and $facts['os']['release']['major'] == '7') { + require epel } contain rabbitmq::install diff --git a/spec/acceptance/class_spec.rb b/spec/acceptance/class_spec.rb index 009b35b08..b6496ebf6 100644 --- a/spec/acceptance/class_spec.rb +++ b/spec/acceptance/class_spec.rb @@ -15,11 +15,7 @@ context 'default class inclusion' do let(:pp) do <<-EOS - class { 'rabbitmq': } - if $facts['os']['family'] == 'RedHat' { - class { 'erlang': epel_enable => true} - Class['erlang'] -> Class['rabbitmq'] - } + include rabbitmq EOS end @@ -54,10 +50,6 @@ class { 'erlang': epel_enable => true} class { 'rabbitmq': service_ensure => 'stopped', } - if $facts['os']['family'] == 'RedHat' { - class { 'erlang': epel_enable => true} - Class['erlang'] -> Class['rabbitmq'] - } EOS end @@ -73,10 +65,6 @@ class { 'erlang': epel_enable => true} it 'runs successfully' do pp_pre = <<-EOS class { 'rabbitmq': } - if $facts['os']['family'] == 'RedHat' { - class { 'erlang': epel_enable => true} - Class['erlang'] -> Class['rabbitmq'] - } EOS pp = <<-EOS @@ -84,10 +72,6 @@ class { 'rabbitmq': service_manage => false, service_ensure => 'stopped', } - if $facts['os']['family'] == 'RedHat' { - class { 'erlang': epel_enable => true} - Class['erlang'] -> Class['rabbitmq'] - } EOS apply_manifest(pp_pre, catch_failures: true) diff --git a/spec/acceptance/clustering_spec.rb b/spec/acceptance/clustering_spec.rb index fa689cf42..3f7863268 100644 --- a/spec/acceptance/clustering_spec.rb +++ b/spec/acceptance/clustering_spec.rb @@ -15,7 +15,7 @@ class { 'rabbitmq': wipe_db_on_cookie_change => false, } if $facts['os']['family'] == 'RedHat' { - class { 'erlang': epel_enable => true} + class { 'erlang': } Class['erlang'] -> Class['rabbitmq'] } EOS @@ -40,7 +40,7 @@ class { 'rabbitmq': wipe_db_on_cookie_change => true, } if $facts['os']['family'] == 'RedHat' { - class { 'erlang': epel_enable => true} + class { 'erlang': } Class['erlang'] -> Class['rabbitmq'] } EOS @@ -85,7 +85,7 @@ class { 'rabbitmq': erlang_cookie => 'TESTCOOKIE', } if $facts['os']['family'] == 'RedHat' { - class { 'erlang': epel_enable => true} + class { 'erlang': } Class['erlang'] -> Class['rabbitmq'] } EOS diff --git a/spec/acceptance/delete_guest_user_spec.rb b/spec/acceptance/delete_guest_user_spec.rb index 15bdff93f..3a1e3f6fb 100644 --- a/spec/acceptance/delete_guest_user_spec.rb +++ b/spec/acceptance/delete_guest_user_spec.rb @@ -11,7 +11,7 @@ class { 'rabbitmq': delete_guest_user => true, } if $facts['os']['family'] == 'RedHat' { - class { 'erlang': epel_enable => true} + class { 'erlang': } Class['erlang'] -> Class['rabbitmq'] } EOS diff --git a/spec/acceptance/parameter_spec.rb b/spec/acceptance/parameter_spec.rb index 38ed4b53a..3c440f6dc 100644 --- a/spec/acceptance/parameter_spec.rb +++ b/spec/acceptance/parameter_spec.rb @@ -7,7 +7,7 @@ it 'runs successfully' do pp = <<-EOS if $facts['os']['family'] == 'RedHat' { - class { 'erlang': epel_enable => true } + class { 'erlang': } Class['erlang'] -> Class['rabbitmq'] } class { 'rabbitmq': diff --git a/spec/acceptance/policy_spec.rb b/spec/acceptance/policy_spec.rb index 1cd126344..1332b3149 100644 --- a/spec/acceptance/policy_spec.rb +++ b/spec/acceptance/policy_spec.rb @@ -7,7 +7,7 @@ it 'runs successfully' do pp = <<-EOS if $facts['os']['family'] == 'RedHat' { - class { 'erlang': epel_enable => true } + class { 'erlang': } Class['erlang'] -> Class['rabbitmq'] } class { 'rabbitmq': diff --git a/spec/acceptance/queue_spec.rb b/spec/acceptance/queue_spec.rb index 2934796e9..3d3f5a2d6 100644 --- a/spec/acceptance/queue_spec.rb +++ b/spec/acceptance/queue_spec.rb @@ -7,7 +7,7 @@ it 'runs successfully' do pp = <<-EOS if $facts['os']['family'] == 'RedHat' { - class { 'erlang': epel_enable => true } + class { 'erlang': } Class['erlang'] -> Class['rabbitmq'] } class { 'rabbitmq': @@ -81,7 +81,7 @@ class { 'rabbitmq': it 'runs successfully' do pp = <<-EOS if $facts['os']['family'] == 'RedHat' { - class { 'erlang': epel_enable => true } + class { 'erlang': } Class['erlang'] -> Class['rabbitmq'] } class { 'rabbitmq': @@ -169,7 +169,7 @@ class { 'rabbitmq': it 'runs successfully' do pp = <<-EOS if $facts['os']['family'] == 'RedHat' { - class { 'erlang': epel_enable => true } + class { 'erlang': } Class['erlang'] -> Class['rabbitmq'] } class { 'rabbitmq': diff --git a/spec/acceptance/rabbitmqadmin_spec.rb b/spec/acceptance/rabbitmqadmin_spec.rb index fa127f1b4..9f4fa8a30 100644 --- a/spec/acceptance/rabbitmqadmin_spec.rb +++ b/spec/acceptance/rabbitmqadmin_spec.rb @@ -11,7 +11,7 @@ class { 'rabbitmq': service_manage => true, } if $facts['os']['family'] == 'RedHat' { - class { 'erlang': epel_enable => true} + class { 'erlang': } Class['erlang'] -> Class['rabbitmq'] } EOS @@ -32,7 +32,7 @@ class { 'rabbitmq': service_manage => false, } if $facts['os']['family'] == 'RedHat' { - class { 'erlang': epel_enable => true} + class { 'erlang': } Class['erlang'] -> Class['rabbitmq'] } EOS @@ -56,7 +56,7 @@ class { 'rabbitmq': default_pass => 'bazblam', } if $facts['os']['family'] == 'RedHat' { - class { 'erlang': epel_enable => true} + class { 'erlang': } Class['erlang'] -> Class['rabbitmq'] } EOS @@ -69,7 +69,7 @@ class { 'rabbitmq': default_pass => 'bazblam', } if $facts['os']['family'] == 'RedHat' { - class { 'erlang': epel_enable => true} + class { 'erlang': } Class['erlang'] -> Class['rabbitmq'] } EOS diff --git a/spec/acceptance/user_spec.rb b/spec/acceptance/user_spec.rb index a8d369218..bd95e8320 100644 --- a/spec/acceptance/user_spec.rb +++ b/spec/acceptance/user_spec.rb @@ -7,7 +7,7 @@ it 'runs successfully' do pp = <<-EOS if $facts['os']['family'] == 'RedHat' { - class { 'erlang': epel_enable => true } + class { 'erlang': } Class['erlang'] -> Class['rabbitmq'] } class { 'rabbitmq': diff --git a/spec/acceptance/vhost_spec.rb b/spec/acceptance/vhost_spec.rb index 782e33df9..fa63f12c1 100644 --- a/spec/acceptance/vhost_spec.rb +++ b/spec/acceptance/vhost_spec.rb @@ -7,7 +7,7 @@ it 'runs successfully' do pp = <<-EOS if $facts['os']['family'] == 'RedHat' { - class { 'erlang': epel_enable => true } + class { 'erlang': } Class['erlang'] -> Class['rabbitmq'] } class { 'rabbitmq': diff --git a/spec/spec_helper_acceptance.rb b/spec/spec_helper_acceptance.rb index a4332b42f..742248bc0 100644 --- a/spec/spec_helper_acceptance.rb +++ b/spec/spec_helper_acceptance.rb @@ -7,7 +7,8 @@ when 'Debian' install_puppet_module_via_pmt_on(host, 'puppetlabs-apt', '>= 4.1.0 < 9.0.0') when 'RedHat' - install_puppet_module_via_pmt_on(host, 'garethr-erlang', '>= 0.3.0 < 1.0.0') + install_puppet_module_via_pmt_on(host, 'puppet-erlang', '>= 1.1.0 < 2.0.0') + install_puppet_module_via_pmt_on(host, 'puppet-epel', '>= 5.0.0 < 6.0.0') if fact_on(host, 'os.selinux.enabled') # Make sure selinux is disabled so the tests work. on host, puppet('resource', 'exec', 'setenforce 0', 'path=/bin:/sbin:/usr/bin:/usr/sbin', 'onlyif=which setenforce && getenforce | grep Enforcing')