Skip to content

manage the service#243

Open
epik0r wants to merge 1 commit intovoxpupuli:masterfrom
epik0r:forwarder
Open

manage the service#243
epik0r wants to merge 1 commit intovoxpupuli:masterfrom
epik0r:forwarder

Conversation

@epik0r
Copy link
Copy Markdown

@epik0r epik0r commented Jul 16, 2019

This pull request add the option service_ensure, to make it possible to stop the service in case.

@nick-markowski
Copy link
Copy Markdown
Contributor

@bc-bjoern Good idea, we should probably do the same with splunk enterprise. Would you mind updating the acceptance suite to toggle the ensure from running to stopped to test for validity? I can help if you'd like, let me know :)

@epik0r
Copy link
Copy Markdown
Author

epik0r commented Jul 24, 2019

Hey, may you can help me out here.
This "["running", "stopped"]" doesn't work.

should contain Service[SplunkForwarder] with ensure => ["running", "stopped"], enable => true, status defined, restart defined, start defined and stop defined (FAILED - 1)

@nick-markowski
Copy link
Copy Markdown
Contributor

I'm doing a minor refactor to push params to moduledata, I'll incorporate this change with it and ping you when it's submitted for a PR

@epik0r
Copy link
Copy Markdown
Author

epik0r commented Jul 29, 2019

Well okay, thank you!

@nick-markowski
Copy link
Copy Markdown
Contributor

#250

@juniorsysadmin juniorsysadmin added the enhancement New feature or request label Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request needs-tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants