Remove curly brackets from interface name (#126)#135
Conversation
|
Since the title of this pull request would be used in the changelog, could you come up with a better title that says something about the bug that is being fixed? |
|
Seems new checks are present, which have nothing to do with my PR. I hope my commit message is a bit better now. |
The powershell commands places curly brackets around the name of the interfaces, this causes an apply on the resource windowsfirewall with the parameter disabled_interface_aliases every run. This will fix it.
|
Changed the commit message and see it is also green now. Tested this code on a Windows 2019 machine with: windowsfirewall { 'domain': |
The command
Get-NetFirewallProfileshows the variableDisabledInterfaceAliaseswith curly brackets, causing every run to change this parameter. Delete all curly brackets from value to solve this.Pull Request (PR) description
The output of
DisabledInterfaceAliasesgives curly brackets around the interface-name. Added a delete to the provider to delete these.This Pull Request (PR) fixes the following issues
Fixes #126