Skip to content

Conversation

@jameskirsop
Copy link
Contributor

Pull Request (PR) description

This PR adds support for the 2 FPM configurations mentioned here that appear to resolve issues with FPM memory usage on RHEL/CentOS hosts.

This Pull Request (PR) fixes the following issues

No issues related to this PR

Copy link
Member

@root-expert root-expert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Please add specs for the two new parameters

Optional[Stdlib::Absolutepath] $saml_sp_key = $zabbix::params::saml_sp_key,
Optional[Stdlib::Absolutepath] $saml_sp_cert = $zabbix::params::saml_sp_cert,
Optional[Stdlib::Absolutepath] $saml_idp_cert = $zabbix::params::saml_idp_cert,
Optional[Integer[1, 10000]] $fpm_max_requests = $zabbix::params::fpm_max_requests,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default this to undef on params class

@root-expert root-expert added enhancement New feature or request needs-tests labels May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request needs-tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants