Add support to measure status_codes#317
Conversation
|
@wpjunior Thanks contribute. Unfortunately, the status dash board(html page) seems to corrupt the series of N/A appered suddenly in server zone. Note that the page is used by many users now a day, they will suprise what happened when the feature turn on. |
|
Hi @u5surf, I extracted the status codes into a separate JSON structure, so the status page is still working as before. I believe I have finished the merge request. |
|
Hi @u5surf I implemented this feature :-) |
|
@wpjunior BTW, I have an another suggestion for you about this pull request. |
|
Hi @u5surf, Creating filters is a powerful tool. However, the current implementation seems to generate Prometheus metrics with two somewhat confusing dimensions: filter and filter_name. Making the status code a first-class attribute would simplify the metrics, making them easier for entry-level users to adopt. Yeah, let's talk on LinkedIn! |
|
@wpjunior In addition some nit picks. At last I would be merge this if you will have finished some fixes. Thanks for a while! @SuperQ Could you review this PR? Because this is a significant change for this module. For we have to make a decision to merge this, I'd like hear more collaboraters agree with the feature or not. |
|
@wpjunior Sorry for long time no response! I’ve decided to merge your PR because other reviewers had no response, I’ve no claimed you the change request anymore. Finally, could you fix a several chore conflict? |
…rometheus displays
Co-authored-by: Y.Horie <u5.horie@gmail.com>
Co-authored-by: Y.Horie <u5.horie@gmail.com>
2a4b75a to
f6ac339
Compare
|
Hi @u5surf, I am happy to made this git rebase, done my friend |
|
@wpjunior Thanks! It’s all done! |
|
Huge thanks for this update @wpjunior Already tried, works like a charm for the Prometheus metrics format 🙏 |

#154