Skip to content

Performance Optimizations using std::move and constexpr #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2024
Merged

Performance Optimizations using std::move and constexpr #66

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f94077
Replaced const with constexpr, to allow compiler to define various th…
evanwporter Aug 22, 2024
f762ce5
Added move semantics (via std::move within the utility lib). This has…
evanwporter Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions include/decimal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,19 @@
#define DEC_OVERRIDE override
#endif

#ifdef DEC_NO_CPP11
#define DEC_CONSTEXPR const
#else
#define DEC_CONSTEXPR constexpr
#endif

#ifdef DEC_NO_CPP11
#define DEC_MOVE(x) (x)
#else
#include <utility>
#define DEC_MOVE(x) std::move(x)
#endif

#if (DEC_ALLOW_SPACESHIP_OPER == 1) && (__cplusplus > 201703L)
#define DEC_USE_SPACESHIP_OPER 1
#else
Expand Down Expand Up @@ -188,27 +201,27 @@ enum {
// Class definitions
// ----------------------------------------------------------------------------
template<int Prec> struct DecimalFactor {
static const int64 value = 10 * DecimalFactor<Prec - 1>::value;
static DEC_CONSTEXPR int64 value = 10 * DecimalFactor<Prec - 1>::value;
};

template<> struct DecimalFactor<0> {
static const int64 value = 1;
static DEC_CONSTEXPR int64 value = 1;
};

template<> struct DecimalFactor<1> {
static const int64 value = 10;
static DEC_CONSTEXPR int64 value = 10;
};

template<int Prec, bool positive> struct DecimalFactorDiff_impl {
static const int64 value = DecimalFactor<Prec>::value;
static DEC_CONSTEXPR int64 value = DecimalFactor<Prec>::value;
};

template<int Prec> struct DecimalFactorDiff_impl<Prec, false> {
static const int64 value = INT64_MIN;
static DEC_CONSTEXPR int64 value = INT64_MIN;
};

template<int Prec> struct DecimalFactorDiff {
static const int64 value = DecimalFactorDiff_impl<Prec, Prec >= 0>::value;
static DEC_CONSTEXPR int64 value = DecimalFactorDiff_impl<Prec, Prec >= 0>::value;
};

#ifndef DEC_EXTERNAL_ROUND
Expand Down Expand Up @@ -1935,7 +1948,7 @@ bool fromStream(StreamType &input, const basic_decimal_format &format, decimal_t

ostringstream out;
toStream(arg, format, out);
output = out.str();
output = DEC_MOVE(out.str());
return output;
}

Expand All @@ -1946,7 +1959,7 @@ bool fromStream(StreamType &input, const basic_decimal_format &format, decimal_t

ostringstream out;
toStream(arg, out);
output = out.str();
output = DEC_MOVE(out.str());
return output;
}

Expand Down