Merge pull request #968 from siystar/waitstages

robertosfield · web-flow · commit a1f7d8600db0 · 2023-09-16T15:49:27.000+01:00
[FIXED] TransferTask semaphore wait stages
diff --git a/src/vsg/app/TransferTask.cpp b/src/vsg/app/TransferTask.cpp
@@ -360,7 +360,7 @@ VkResult TransferTask::transferDynamicData()
 
     if (!semaphore)
     {
-        semaphore = Semaphore::create(device, VK_PIPELINE_STAGE_TRANSFER_BIT);
+        semaphore = Semaphore::create(device, VK_PIPELINE_STAGE_ALL_COMMANDS_BIT);
     }
 
     VkResult result = VK_SUCCESS;
@@ -395,7 +395,7 @@ VkResult TransferTask::transferDynamicData()
 
     vkEndCommandBuffer(vk_commandBuffer);
 
-    // if no regions to copy have been found then commandBuffer will be empty so no need to submit it to queue and use the associated single semaphore
+    // if no regions to copy have been found then commandBuffer will be empty so no need to submit it to queue and signal the associated semaphore
     if (offset > 0)
     {
         // submit the transfer commands

Original file line number	Diff line number	Diff line change
`@@ -360,7 +360,7 @@ VkResult TransferTask::transferDynamicData()`
`360`	`360`
`361`	`361`	`if (!semaphore)`
`362`	`362`	`{`
`363`		`- semaphore = Semaphore::create(device, VK_PIPELINE_STAGE_TRANSFER_BIT);`
	`363`	`+ semaphore = Semaphore::create(device, VK_PIPELINE_STAGE_ALL_COMMANDS_BIT);`
`364`	`364`	`}`
`365`	`365`
`366`	`366`	`VkResult result = VK_SUCCESS;`
`@@ -395,7 +395,7 @@ VkResult TransferTask::transferDynamicData()`
`395`	`395`
`396`	`396`	`vkEndCommandBuffer(vk_commandBuffer);`
`397`	`397`
`398`		`- // if no regions to copy have been found then commandBuffer will be empty so no need to submit it to queue and use the associated single semaphore`
	`398`	`+ // if no regions to copy have been found then commandBuffer will be empty so no need to submit it to queue and signal the associated semaphore`
`399`	`399`	`if (offset > 0)`
`400`	`400`	`{`
`401`	`401`	`// submit the transfer commands`