refactor: extract common log fields and remove data from diagnosticsLog

This commit addresses PR review feedback by refactoring the logger to
improve code maintainability and prevent data duplication between console
and diagnostics client logs.

Key changes:
- Created commonLogFields object containing shared fields: __VTEX_IO_LOG,
  level, operationId, requestId, and traceId
- Removed data field from diagnosticsLog by keeping it only in inflatedLog
- Spread commonLogFields at the end of both log objects to maintain key order

The refactoring ensures:
1. Console logs (inflatedLog) include all fields needed for fluent-bit/OpenSearch
2. Diagnostics client logs (diagnosticsLog) use semantic convention keys without
   data duplication
3. Common fields are defined once and reused consistently across both log formats

Addresses review comments from @juliobguedes:
- Comment 1: Remove data from diagnosticsLog to avoid duplications
- Comment 2: Extract commonLogFields to reduce code duplication

Author: daniyelnnr

src/service/logger/logger.ts

@@ -79,17 +79,21 @@ export class Logger {
     cleanLog(data)
 
     /* tslint:disable:object-literal-sort-keys */
-    const inflatedLog = {
+    const commonLogFields = {
       __VTEX_IO_LOG: true,
       level,
+      operationId: this.operationId,
+      requestId: this.requestId,
+      ... (this.tracingState?.isTraceSampled ? { traceId: this.tracingState.traceId } : null),
+    }
+
+    const inflatedLog = {
       app,
       account: this.account,
       workspace: this.workspace,
       production: this.production,
-      operationId: this.operationId,
-      requestId: this.requestId,
       data,
-      ... (this.tracingState?.isTraceSampled ? { traceId: this.tracingState.traceId } : null),
+      ...commonLogFields,
     }
 
     // Mark third-party apps logs to send to skidder
@@ -103,17 +107,12 @@ export class Logger {
     console.log(JSON.stringify(inflatedLog))
 
     const diagnosticsLog = {
-      __VTEX_IO_LOG: true,
-      level,
       [AttributeKeys.VTEX_IO_APP_ID]: app,
       [AttributeKeys.VTEX_ACCOUNT_NAME]: this.account,
       [AttributeKeys.VTEX_IO_WORKSPACE_NAME]: this.workspace,
       [AttributeKeys.VTEX_IO_WORKSPACE_TYPE]: this.production ? 'production' : 'development',
       [AttributeKeys.VTEX_IO_APP_AUTHOR_TYPE]: APP.IS_THIRD_PARTY() ? '3p' : '1p',
-      operationId: this.operationId,
-      requestId: this.requestId,
-      data,
-      ... (this.tracingState?.isTraceSampled ? { traceId: this.tracingState.traceId } : null),
+      ...commonLogFields,
     }
 
     if (this.logClient) {