-
Notifications
You must be signed in to change notification settings - Fork 16
Enable telemetry control from env vars #605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
df51513
Bump diagnostics-nodejs version
daniyelnnr aa2e3bb
Refactor telemetry client to support all signals
daniyelnnr 35428ee
Refactor getLogClient to simplify initialization
daniyelnnr 536e16c
Refactor logger client types
daniyelnnr b5b2425
Add resolution for @grpc/grpc-js dependency
daniyelnnr ec13074
Update package version to 6.49.8-beta.0
daniyelnnr 00afbcb
Refactor singleton to use dedicated initialization methods for teleme…
daniyelnnr f3d9c05
Refactor telemetry client initialization logic
daniyelnnr 58d03c9
Update package.json and yarn.lock
daniyelnnr cfac3a1
Update startApp function to proper init telemetry
daniyelnnr 48127f3
Add metrics client
daniyelnnr e10016d
Add metrics instruments for monitoring HTTP requests
daniyelnnr c1d29a9
Add middleware for request metrics
daniyelnnr 4549879
Add middleware usage on app
daniyelnnr cf53947
Add Koa instrumentation to telemetry client
daniyelnnr 7faeac7
Add Koa context propagation middleware to app worker
daniyelnnr 41f7dee
Add host-metrics instrumentation
daniyelnnr 5b5146d
Add host-metrics instrumentation to telemetry client
daniyelnnr 8b715bd
Merge branch 'master' into chore/bump-diagnostics
daniyelnnr 6503f4d
Release v7.0.1
daniyelnnr c9bde12
Merge branch 'chore/bump-diagnostics' into update/metrics
daniyelnnr ff3bbb9
Release v7.1.0-beta.0
daniyelnnr b54e413
Improves code formatting for setTimeout
daniyelnnr b596cc7
Refactor instrument init logic on middleware
daniyelnnr 08bef4e
Refactor metric client module
daniyelnnr 1477054
Refactor metrics instruments module
daniyelnnr 6733ee2
Add error handling when init instruments
daniyelnnr b0c660b
Merge branch 'master' into update/metrics
daniyelnnr 274859c
Bump @vtex/diagnostics-nodejs to 0.1.0-io-beta.20
daniyelnnr 5f78b47
Add new constants for diagnostics configuration
daniyelnnr 8c792fa
Enable log client initialization
daniyelnnr d236aa6
Add new constants to client.ts
daniyelnnr 43fb4b1
Make clients use new constant for endpoint
daniyelnnr 51f31ea
Use DK_APP_ID on telemetry client creation
daniyelnnr f41b421
Refactor telemetry client parameters
daniyelnnr 1c9f5d6
Refactor telemetry client initialization with checks
daniyelnnr 92e0b75
Update constant default value
daniyelnnr ed60b8e
improve logging approach for telemetry status
daniyelnnr bd3149b
Add new attributes to telemetry client
daniyelnnr e990260
Merge branch 'master' into config/enable-telemetry-controls
daniyelnnr a5de07e
release v7.1.1
daniyelnnr 9ee3b6b
update CHANGELOG
daniyelnnr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wha is the role of this DK app id here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a request from o11y team, the proper identifier for this first parameter should be the DK app id instead of the composite id (vendor, app name and version) that we were using here - that's the reason why I opened #602 and proper onboard node-vtex-api.