fix: review feedback

alex-snezhko · alex-snezhko · commit f695bc3288b5 · 2025-06-15T19:51:54.000-07:00
diff --git a/packages/runtime-core/src/renderer.ts b/packages/runtime-core/src/renderer.ts
@@ -621,10 +621,11 @@ function baseCreateRenderer(
         optimized,
       )
     } else {
-      if (n1.el && (n1.el as VueElement)._isVueCE) {
-        ;(n1.el as VueElement)._beginPatch()
-      }
+      const isVueCE = !!(n1.el && (n1.el as VueElement)._isVueCE)
       try {
+        if (isVueCE) {
+          ;(n1.el as VueElement)._beginPatch()
+        }
         patchElement(
           n1,
           n2,
@@ -635,7 +636,7 @@ function baseCreateRenderer(
           optimized,
         )
       } finally {
-        if (n1.el && (n1.el as VueElement)._isVueCE) {
+        if (isVueCE) {
           ;(n1.el as VueElement)._endPatch()
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -621,10 +621,11 @@ function baseCreateRenderer(`
`621`	`621`	`optimized,`
`622`	`622`	`)`
`623`	`623`	`} else {`
`624`		`- if (n1.el && (n1.el as VueElement)._isVueCE) {`
`625`		`- ;(n1.el as VueElement)._beginPatch()`
`626`		`- }`
	`624`	`+ const isVueCE = !!(n1.el && (n1.el as VueElement)._isVueCE)`
`627`	`625`	`try {`
	`626`	`+ if (isVueCE) {`
	`627`	`+ ;(n1.el as VueElement)._beginPatch()`
	`628`	`+ }`
`628`	`629`	`patchElement(`
`629`	`630`	`n1,`
`630`	`631`	`n2,`
`@@ -635,7 +636,7 @@ function baseCreateRenderer(`
`635`	`636`	`optimized,`
`636`	`637`	`)`
`637`	`638`	`} finally {`
`638`		`- if (n1.el && (n1.el as VueElement)._isVueCE) {`
	`639`	`+ if (isVueCE) {`
`639`	`640`	`;(n1.el as VueElement)._endPatch()`
`640`	`641`	`}`
`641`	`642`	`}`