fix(slots): make cache indexes marker non-enumerable

[edison1105]

close #13468

Summary by CodeRabbit

• Bug Fixes
  • Improved slot handling to ensure internal compiler markers remain hidden from slot enumerations, preventing them from appearing in user-visible slot lists.

[coderabbitai]

Walkthrough

The initSlots function in componentSlots.ts was updated to extract a __ property from the children object when initializing slots. If present, this property is defined as a non-enumerable property on the slots object using the def utility, before proceeding with the existing slot normalization logic.

Changes

File(s)	Change Summary
packages/runtime-core/src/componentSlots.ts	Modified initSlots to extract and define a __ property from children onto slots if found
packages/runtime-core/tests/componentSlots.spec.ts	Added test to verify _ and __ properties on slots are non-enumerable and do not appear in Object.keys

Sequence Diagram(s)

sequenceDiagram
    participant VNode
    participant initSlots
    participant slots
    participant def

    VNode->>initSlots: Pass children with possible __ property
    initSlots->>initSlots: Check if children has __ property
    alt __ property exists
        initSlots->>def: Define __ property on slots as non-enumerable
    end
    initSlots->>slots: Continue slot normalization

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Restore slot behavior to match Vue 3.5.13, ensuring iterating slots and extracting props works as before (#13468)	✅

Poem

In the warren of code, a slot hops anew,
With a hidden cache, tucked out of view.
Non-enumerable magic, the rabbit did bring,
Restoring old habits—oh, what a spring!
Now Vue slots behave, as they once did delight,
Thanks to a bunny who codes through the night. 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 61d75e1 and 0c82d7c.

📒 Files selected for processing (1)

• packages/runtime-core/__tests__/componentSlots.spec.ts (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• packages/runtime-core/tests/componentSlots.spec.ts

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	101 kB (+29 B)	38.4 kB (+15 B)	34.6 kB (+12 B)
vue.global.prod.js	159 kB (+30 B)	58.6 kB (+16 B)	52.2 kB (-1 B)

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	46.7 kB (+29 B)	18.2 kB (+16 B)	16.7 kB (+18 B)
createApp	54.7 kB (+29 B)	21.3 kB (+18 B)	19.5 kB (+18 B)
createSSRApp	58.9 kB (+29 B)	23 kB (+19 B)	21 kB (+18 B)
defineCustomElement	59.6 kB (+29 B)	22.9 kB (+21 B)	20.9 kB (+1 B)
overall	68.8 kB (+29 B)	26.5 kB (+15 B)	24.2 kB (+83 B)

[pkg-pr-new]

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13469

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13469

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13469

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13469

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13469

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13469

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13469

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13469

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13469

vue

npm i https://pkg.pr.new/vue@13469

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13469

commit: 0c82d7c

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4fdb550 and 61d75e1.

📒 Files selected for processing (1)

• packages/runtime-core/__tests__/componentSlots.spec.ts (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: Redirect rules
• GitHub Check: Header rules
• GitHub Check: Pages changed
• GitHub Check: test / e2e-test
• GitHub Check: test / unit-test-windows