From d1479f219651fdf7d4bb9fdd17b6f77e18549808 Mon Sep 17 00:00:00 2001
From: waynzh <waynzh19@gmail.com>
Date: Fri, 30 Aug 2024 15:46:42 +0800
Subject: [PATCH 1/6] feat: add no-deprecated-delete-set rule

---
 docs/rules/index.md                         |   1 +
 docs/rules/no-deprecated-delete-set.md      |  49 ++++
 lib/configs/flat/vue3-essential.js          |   1 +
 lib/configs/vue3-essential.js               |   1 +
 lib/index.js                                |   1 +
 lib/rules/no-deprecated-delete-set.js       | 141 +++++++++
 tests/lib/rules/no-deprecated-delete-set.js | 308 ++++++++++++++++++++
 7 files changed, 502 insertions(+)
 create mode 100644 docs/rules/no-deprecated-delete-set.md
 create mode 100644 lib/rules/no-deprecated-delete-set.js
 create mode 100644 tests/lib/rules/no-deprecated-delete-set.js

diff --git a/docs/rules/index.md b/docs/rules/index.md
index 113ff416b..0d3ea5c4b 100644
--- a/docs/rules/index.md
+++ b/docs/rules/index.md
@@ -48,6 +48,7 @@ Rules in this category are enabled for all presets provided by eslint-plugin-vue
 | [vue/no-computed-properties-in-data](./no-computed-properties-in-data.md) | disallow accessing computed properties in `data` |  | :three::two::warning: |
 | [vue/no-custom-modifiers-on-v-model](./no-custom-modifiers-on-v-model.md) | disallow custom modifiers on v-model used on the component |  | :two::warning: |
 | [vue/no-deprecated-data-object-declaration](./no-deprecated-data-object-declaration.md) | disallow using deprecated object declaration on data (in Vue.js 3.0.0+) | :wrench: | :three::warning: |
+| [vue/no-deprecated-delete-set](./no-deprecated-delete-set.md) | disallow using deprecated `$delete` and `$set` (in Vue.js 3.0.0+) |  | :three::warning: |
 | [vue/no-deprecated-destroyed-lifecycle](./no-deprecated-destroyed-lifecycle.md) | disallow using deprecated `destroyed` and `beforeDestroy` lifecycle hooks (in Vue.js 3.0.0+) | :wrench: | :three::warning: |
 | [vue/no-deprecated-dollar-listeners-api](./no-deprecated-dollar-listeners-api.md) | disallow using deprecated `$listeners` (in Vue.js 3.0.0+) |  | :three::warning: |
 | [vue/no-deprecated-dollar-scopedslots-api](./no-deprecated-dollar-scopedslots-api.md) | disallow using deprecated `$scopedSlots` (in Vue.js 3.0.0+) | :wrench: | :three::warning: |
diff --git a/docs/rules/no-deprecated-delete-set.md b/docs/rules/no-deprecated-delete-set.md
new file mode 100644
index 000000000..20a33fe58
--- /dev/null
+++ b/docs/rules/no-deprecated-delete-set.md
@@ -0,0 +1,49 @@
+---
+pageClass: rule-details
+sidebarDepth: 0
+title: vue/no-deprecated-delete-set
+description: disallow using deprecated `$delete` and `$set` (in Vue.js 3.0.0+)
+---
+
+# vue/no-deprecated-delete-set
+
+> disallow using deprecated `$delete` and `$set` (in Vue.js 3.0.0+)
+
+- :exclamation: <badge text="This rule has not been released yet." vertical="middle" type="error"> _**This rule has not been released yet.**_ </badge>
+- :gear: This rule is included in all of `"plugin:vue/vue3-essential"`, `*.configs["flat/essential"]`, `"plugin:vue/vue3-strongly-recommended"`, `*.configs["flat/strongly-recommended"]`, `"plugin:vue/vue3-recommended"` and `*.configs["flat/recommended"]`.
+
+## :book: Rule Details
+
+This rule reports use of deprecated `$delete` and `$set`. (in Vue.js 3.0.0+).
+
+<eslint-code-block :rules="{'vue/no-deprecated-delete-set': ['error']}">
+
+```vue
+<script>
+  import { set as st, delete as del } from 'vue'
+  export default {
+    mounted () {
+      /* ✗ BAD */
+      this.$set(obj, key, value)
+      this.$delete(obj, key)
+
+      Vue.set(obj, key, value)
+      Vue.delete(obj, key)
+
+      st(obj, key, value)
+      del(obj, key)
+    }
+  }
+</script>
+```
+
+</eslint-code-block>
+
+## :wrench: Options
+
+Nothing.
+
+## :mag: Implementation
+
+- [Rule source](https://github.com/vuejs/eslint-plugin-vue/blob/master/lib/rules/no-deprecated-delete-set.js)
+- [Test source](https://github.com/vuejs/eslint-plugin-vue/blob/master/tests/lib/rules/no-deprecated-delete-set.js)
diff --git a/lib/configs/flat/vue3-essential.js b/lib/configs/flat/vue3-essential.js
index 18d8c8570..50a6d6787 100644
--- a/lib/configs/flat/vue3-essential.js
+++ b/lib/configs/flat/vue3-essential.js
@@ -17,6 +17,7 @@ module.exports = [
       'vue/no-child-content': 'error',
       'vue/no-computed-properties-in-data': 'error',
       'vue/no-deprecated-data-object-declaration': 'error',
+      'vue/no-deprecated-delete-set': 'error',
       'vue/no-deprecated-destroyed-lifecycle': 'error',
       'vue/no-deprecated-dollar-listeners-api': 'error',
       'vue/no-deprecated-dollar-scopedslots-api': 'error',
diff --git a/lib/configs/vue3-essential.js b/lib/configs/vue3-essential.js
index f71508f75..c58520f26 100644
--- a/lib/configs/vue3-essential.js
+++ b/lib/configs/vue3-essential.js
@@ -12,6 +12,7 @@ module.exports = {
     'vue/no-child-content': 'error',
     'vue/no-computed-properties-in-data': 'error',
     'vue/no-deprecated-data-object-declaration': 'error',
+    'vue/no-deprecated-delete-set': 'error',
     'vue/no-deprecated-destroyed-lifecycle': 'error',
     'vue/no-deprecated-dollar-listeners-api': 'error',
     'vue/no-deprecated-dollar-scopedslots-api': 'error',
diff --git a/lib/index.js b/lib/index.js
index ff3f69c6e..60bccf38c 100644
--- a/lib/index.js
+++ b/lib/index.js
@@ -96,6 +96,7 @@ const plugin = {
     'no-constant-condition': require('./rules/no-constant-condition'),
     'no-custom-modifiers-on-v-model': require('./rules/no-custom-modifiers-on-v-model'),
     'no-deprecated-data-object-declaration': require('./rules/no-deprecated-data-object-declaration'),
+    'no-deprecated-delete-set': require('./rules/no-deprecated-delete-set'),
     'no-deprecated-destroyed-lifecycle': require('./rules/no-deprecated-destroyed-lifecycle'),
     'no-deprecated-dollar-listeners-api': require('./rules/no-deprecated-dollar-listeners-api'),
     'no-deprecated-dollar-scopedslots-api': require('./rules/no-deprecated-dollar-scopedslots-api'),
diff --git a/lib/rules/no-deprecated-delete-set.js b/lib/rules/no-deprecated-delete-set.js
new file mode 100644
index 000000000..1872f45d4
--- /dev/null
+++ b/lib/rules/no-deprecated-delete-set.js
@@ -0,0 +1,141 @@
+/**
+ * @author Wayne Zhang
+ * See LICENSE file in root directory for full license.
+ */
+'use strict'
+
+const utils = require('../utils')
+const { findVariable } = require('@eslint-community/eslint-utils')
+
+const DeprecatedApis = ['set', 'delete']
+const DeprecatedDollarApis = new Set(DeprecatedApis.map((item) => `$${item}`))
+
+/**
+ * @param {Expression|Super} node
+ */
+function isVue(node) {
+  return node.type === 'Identifier' && node.name === 'Vue'
+}
+
+module.exports = {
+  meta: {
+    type: 'problem',
+    docs: {
+      description:
+        'disallow using deprecated `$delete` and `$set` (in Vue.js 3.0.0+)',
+      categories: ['vue3-essential'],
+      url: 'https://eslint.vuejs.org/rules/no-deprecated-delete-set.html'
+    },
+    fixable: null,
+    schema: [],
+    messages: {
+      deprecated: 'The `$delete`, `$set` is deprecated.'
+    }
+  },
+  /** @param {RuleContext} context */
+  create(context) {
+    /**
+     * @param {Identifier} identifier
+     * @param {RuleContext} context
+     * @returns {CallExpression|undefined}
+     */
+    function getVueDeprecatedCallExpression(identifier, context) {
+      // Instance API: this.$set()
+      if (
+        DeprecatedDollarApis.has(identifier.name) &&
+        identifier.parent.type === 'MemberExpression' &&
+        utils.isThis(identifier.parent.object, context) &&
+        identifier.parent.parent.type === 'CallExpression' &&
+        identifier.parent.parent.callee === identifier.parent
+      ) {
+        return identifier.parent.parent
+      }
+
+      // Vue 2 Global API: Vue.set()
+      if (
+        DeprecatedApis.includes(identifier.name) &&
+        identifier.parent.type === 'MemberExpression' &&
+        isVue(identifier.parent.object) &&
+        identifier.parent.parent.type === 'CallExpression' &&
+        identifier.parent.parent.callee === identifier.parent
+      ) {
+        return identifier.parent.parent
+      }
+
+      // Vue 3 Global API
+      if (
+        identifier.parent.type === 'CallExpression' &&
+        identifier.parent.callee === identifier
+      ) {
+        const variable = findVariable(
+          utils.getScope(context, identifier),
+          identifier
+        )
+
+        if (variable != null && variable.defs.length === 1) {
+          const def = variable.defs[0]
+
+          // import { set as st } from 'vue'; st()
+          if (
+            def.type === 'ImportBinding' &&
+            def.node.type === 'ImportSpecifier' &&
+            def.node.imported.type === 'Identifier' &&
+            DeprecatedApis.includes(def.node.imported.name) &&
+            def.node.parent.type === 'ImportDeclaration' &&
+            def.node.parent.source.value === 'vue'
+          ) {
+            return identifier.parent
+          }
+
+          // const { set, delete } = require('vue'); set()
+          if (
+            def.type === 'Variable' &&
+            def.node.type === 'VariableDeclarator' &&
+            def.node.id.type === 'ObjectPattern' &&
+            def.node.init?.type === 'CallExpression' &&
+            def.node.init.callee.type === 'Identifier' &&
+            def.node.init.callee.name === 'require' &&
+            def.node.init.arguments.length === 1 &&
+            def.node.init.arguments[0].type === 'Literal' &&
+            def.node.init.arguments[0].value === 'vue'
+          ) {
+            const properties = def.node.id.properties
+            for (const prop of properties) {
+              if (
+                prop.type === 'Property' &&
+                prop.key.type === 'Identifier' &&
+                DeprecatedApis.includes(prop.key.name) &&
+                prop.value.type === 'Identifier' &&
+                prop.value.name === identifier.name
+              ) {
+                return identifier.parent
+              }
+            }
+          }
+        }
+      }
+
+      return undefined
+    }
+
+    const nodeVisitor = {
+      /** @param {Identifier} node */
+      Identifier(node) {
+        const callExpression = getVueDeprecatedCallExpression(node, context)
+        if (!callExpression) {
+          return
+        }
+
+        context.report({
+          node,
+          messageId: 'deprecated'
+        })
+      }
+    }
+
+    return utils.compositingVisitors(
+      utils.defineVueVisitor(context, nodeVisitor),
+      utils.defineScriptSetupVisitor(context, nodeVisitor)
+    )
+  }
+}
diff --git a/tests/lib/rules/no-deprecated-delete-set.js b/tests/lib/rules/no-deprecated-delete-set.js
new file mode 100644
index 000000000..d13227cd3
--- /dev/null
+++ b/tests/lib/rules/no-deprecated-delete-set.js
@@ -0,0 +1,308 @@
+/**
+ * @author Wayne Zhang
+ * See LICENSE file in root directory for full license.
+ */
+'use strict'
+
+const RuleTester = require('../../eslint-compat').RuleTester
+const rule = require('../../../lib/rules/no-deprecated-delete-set')
+
+const tester = new RuleTester({
+  languageOptions: {
+    parser: require('vue-eslint-parser'),
+    ecmaVersion: 2020,
+    sourceType: 'module'
+  }
+})
+
+tester.run('no-deprecated-delete-set', rule, {
+  valid: [
+    {
+      filename: 'test.js',
+      code: `
+        createApp({
+          mounted () {
+            this.$emit('start')
+          },
+          methods: {
+            click () {
+              this.$emit('click')
+            }
+          }
+        })
+      `
+    },
+    {
+      filename: 'test.js',
+      code: `
+        const another = function () {
+          this.$set(obj, key, value)
+          this.$delete(obj, key)
+        }
+
+        createApp({
+          mounted () {
+            this.$emit('start')
+          }
+        })
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <script>
+          export default {
+            mounted () {
+              a(this.$set)
+              a(this.$delete)
+            }
+          }
+        </script>
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <script>
+        function set(obj, key, value) {}
+        function del(obj, key) {}
+        export default {
+          mounted () {
+            set(obj, key, value)
+            del(obj, key)
+          }
+        }
+        </script>
+      `
+    },
+    // from vue
+    {
+      filename: 'test.js',
+      code: `
+        app.component('some-comp', {
+          mounted () {
+            Vue.nextTick()
+          }
+        })
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <script>
+          import { nextTick as nt, provide } from 'vue'
+          export default {
+            mounted () {
+              nt()
+              provide(key, value)
+            }
+          }
+        </script>
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <script>
+          const { nextTick: nt, provide: del } = require('vue')
+          export default {
+            mounted () {
+              nt()
+              del(key, value)
+            }
+          }
+        </script>
+      `
+    }
+  ],
+
+  invalid: [
+    {
+      filename: 'test.js',
+      code: `
+        app.component('some-comp', {
+          mounted () {
+            this.$set(obj, key, value)
+            this.$delete(obj, key)
+          }
+        })
+      `,
+      errors: [
+        {
+          messageId: 'deprecated',
+          line: 4
+        },
+        {
+          messageId: 'deprecated',
+          line: 5
+        }
+      ]
+    },
+    {
+      filename: 'test.js',
+      code: `
+        app.component('some-comp', {
+          mounted () {
+            const vm = this
+            vm.$set(obj, key, value)
+            vm.$delete(obj, key)
+          }
+        })
+      `,
+      errors: [
+        {
+          messageId: 'deprecated',
+          line: 5
+        },
+        {
+          messageId: 'deprecated',
+          line: 6
+        }
+      ]
+    },
+    {
+      filename: 'test.js',
+      code: `
+        app.component('some-comp', {
+          mounted () {
+            this?.$set(obj, key, value)
+            this?.$delete(obj, key)
+          }
+        })
+      `,
+      errors: [
+        { messageId: 'deprecated', line: 4 },
+        { messageId: 'deprecated', line: 5 }
+      ]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <script>
+          export default {
+            mounted () {
+              this.$set(obj, key, value)
+              this.$delete(obj, key)
+            }
+          }
+        </script>
+      `,
+      errors: [
+        { messageId: 'deprecated', line: 5 },
+        { messageId: 'deprecated', line: 6 }
+      ]
+    },
+    // from vue
+    {
+      filename: 'test.js',
+      code: `
+        app.component('some-comp', {
+          mounted () {
+            Vue.set(obj, key, value)
+            Vue.delete(obj, key)
+          }
+        })
+      `,
+      errors: [
+        {
+          messageId: 'deprecated',
+          line: 4
+        },
+        {
+          messageId: 'deprecated',
+          line: 5
+        }
+      ]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <script>
+          import { set, delete as del } from 'vue'
+          export default {
+            mounted () {
+              set(obj, key, value)
+              del(obj, key)
+            }
+          }
+        </script>
+      `,
+      errors: [
+        {
+          messageId: 'deprecated',
+          line: 6
+        },
+        {
+          messageId: 'deprecated',
+          line: 7
+        }
+      ]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <script setup>
+          import { set, delete as del } from 'vue'
+
+          set(obj, key, value)
+          del(obj, key)
+        </script>
+      `,
+      errors: [
+        {
+          messageId: 'deprecated',
+          line: 5
+        },
+        {
+          messageId: 'deprecated',
+          line: 6
+        }
+      ]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <script>
+          const { set, delete: del } = require('vue')
+          export default {
+            mounted () {
+              set(obj, key, value)
+              del(obj, key)
+            }
+          }
+        </script>
+      `,
+      errors: [
+        {
+          messageId: 'deprecated',
+          line: 6
+        },
+        {
+          messageId: 'deprecated',
+          line: 7
+        }
+      ]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <script setup>
+          const { set, delete: del } = require('vue')
+
+          set(obj, key, value)
+          del(obj, key)
+        </script>
+      `,
+      errors: [
+        {
+          messageId: 'deprecated',
+          line: 5
+        },
+        {
+          messageId: 'deprecated',
+          line: 6
+        }
+      ]
+    }
+  ]
+})

From 72e3c3115e7e2a5aadb70af3673518decc9b338f Mon Sep 17 00:00:00 2001
From: waynzh <waynzh19@gmail.com>
Date: Fri, 30 Aug 2024 17:01:30 +0800
Subject: [PATCH 2/6] feat: address comments

---
 docs/rules/index.md                         |  1 -
 docs/rules/no-deprecated-delete-set.md      |  9 ++-
 lib/configs/flat/vue3-essential.js          |  1 -
 lib/configs/vue3-essential.js               |  1 -
 lib/rules/no-deprecated-delete-set.js       | 15 ++--
 tests/lib/rules/no-deprecated-delete-set.js | 79 ++++++++++++++++-----
 6 files changed, 77 insertions(+), 29 deletions(-)

diff --git a/docs/rules/index.md b/docs/rules/index.md
index 0d3ea5c4b..113ff416b 100644
--- a/docs/rules/index.md
+++ b/docs/rules/index.md
@@ -48,7 +48,6 @@ Rules in this category are enabled for all presets provided by eslint-plugin-vue
 | [vue/no-computed-properties-in-data](./no-computed-properties-in-data.md) | disallow accessing computed properties in `data` |  | :three::two::warning: |
 | [vue/no-custom-modifiers-on-v-model](./no-custom-modifiers-on-v-model.md) | disallow custom modifiers on v-model used on the component |  | :two::warning: |
 | [vue/no-deprecated-data-object-declaration](./no-deprecated-data-object-declaration.md) | disallow using deprecated object declaration on data (in Vue.js 3.0.0+) | :wrench: | :three::warning: |
-| [vue/no-deprecated-delete-set](./no-deprecated-delete-set.md) | disallow using deprecated `$delete` and `$set` (in Vue.js 3.0.0+) |  | :three::warning: |
 | [vue/no-deprecated-destroyed-lifecycle](./no-deprecated-destroyed-lifecycle.md) | disallow using deprecated `destroyed` and `beforeDestroy` lifecycle hooks (in Vue.js 3.0.0+) | :wrench: | :three::warning: |
 | [vue/no-deprecated-dollar-listeners-api](./no-deprecated-dollar-listeners-api.md) | disallow using deprecated `$listeners` (in Vue.js 3.0.0+) |  | :three::warning: |
 | [vue/no-deprecated-dollar-scopedslots-api](./no-deprecated-dollar-scopedslots-api.md) | disallow using deprecated `$scopedSlots` (in Vue.js 3.0.0+) | :wrench: | :three::warning: |
diff --git a/docs/rules/no-deprecated-delete-set.md b/docs/rules/no-deprecated-delete-set.md
index 20a33fe58..6bd4ed829 100644
--- a/docs/rules/no-deprecated-delete-set.md
+++ b/docs/rules/no-deprecated-delete-set.md
@@ -10,7 +10,6 @@ description: disallow using deprecated `$delete` and `$set` (in Vue.js 3.0.0+)
 > disallow using deprecated `$delete` and `$set` (in Vue.js 3.0.0+)
 
 - :exclamation: <badge text="This rule has not been released yet." vertical="middle" type="error"> _**This rule has not been released yet.**_ </badge>
-- :gear: This rule is included in all of `"plugin:vue/vue3-essential"`, `*.configs["flat/essential"]`, `"plugin:vue/vue3-strongly-recommended"`, `*.configs["flat/strongly-recommended"]`, `"plugin:vue/vue3-recommended"` and `*.configs["flat/recommended"]`.
 
 ## :book: Rule Details
 
@@ -20,7 +19,7 @@ This rule reports use of deprecated `$delete` and `$set`. (in Vue.js 3.0.0+).
 
 ```vue
 <script>
-  import { set as st, delete as del } from 'vue'
+  import { set, del } from 'vue'
   export default {
     mounted () {
       /* ✗ BAD */
@@ -30,7 +29,7 @@ This rule reports use of deprecated `$delete` and `$set`. (in Vue.js 3.0.0+).
       Vue.set(obj, key, value)
       Vue.delete(obj, key)
 
-      st(obj, key, value)
+      set(obj, key, value)
       del(obj, key)
     }
   }
@@ -43,6 +42,10 @@ This rule reports use of deprecated `$delete` and `$set`. (in Vue.js 3.0.0+).
 
 Nothing.
 
+## :books: Further Reading
+
+- [Migration Guide - Removed APIs](https://v3-migration.vuejs.org/breaking-changes/#removed-apis)
+
 ## :mag: Implementation
 
 - [Rule source](https://github.com/vuejs/eslint-plugin-vue/blob/master/lib/rules/no-deprecated-delete-set.js)
diff --git a/lib/configs/flat/vue3-essential.js b/lib/configs/flat/vue3-essential.js
index 50a6d6787..18d8c8570 100644
--- a/lib/configs/flat/vue3-essential.js
+++ b/lib/configs/flat/vue3-essential.js
@@ -17,7 +17,6 @@ module.exports = [
       'vue/no-child-content': 'error',
       'vue/no-computed-properties-in-data': 'error',
       'vue/no-deprecated-data-object-declaration': 'error',
-      'vue/no-deprecated-delete-set': 'error',
       'vue/no-deprecated-destroyed-lifecycle': 'error',
       'vue/no-deprecated-dollar-listeners-api': 'error',
       'vue/no-deprecated-dollar-scopedslots-api': 'error',
diff --git a/lib/configs/vue3-essential.js b/lib/configs/vue3-essential.js
index c58520f26..f71508f75 100644
--- a/lib/configs/vue3-essential.js
+++ b/lib/configs/vue3-essential.js
@@ -12,7 +12,6 @@ module.exports = {
     'vue/no-child-content': 'error',
     'vue/no-computed-properties-in-data': 'error',
     'vue/no-deprecated-data-object-declaration': 'error',
-    'vue/no-deprecated-delete-set': 'error',
     'vue/no-deprecated-destroyed-lifecycle': 'error',
     'vue/no-deprecated-dollar-listeners-api': 'error',
     'vue/no-deprecated-dollar-scopedslots-api': 'error',
diff --git a/lib/rules/no-deprecated-delete-set.js b/lib/rules/no-deprecated-delete-set.js
index 1872f45d4..db7724b4e 100644
--- a/lib/rules/no-deprecated-delete-set.js
+++ b/lib/rules/no-deprecated-delete-set.js
@@ -7,8 +7,9 @@
 const utils = require('../utils')
 const { findVariable } = require('@eslint-community/eslint-utils')
 
-const DeprecatedApis = ['set', 'delete']
-const DeprecatedDollarApis = new Set(DeprecatedApis.map((item) => `$${item}`))
+const deprecatedApis = ['set', 'delete']
+const deprecatedImportApis = new Set(['set', 'del'])
+const deprecatedDollarApis = new Set(deprecatedApis.map((item) => `$${item}`))
 
 /**
  * @param {Expression|Super} node
@@ -23,7 +24,7 @@ module.exports = {
     docs: {
       description:
         'disallow using deprecated `$delete` and `$set` (in Vue.js 3.0.0+)',
-      categories: ['vue3-essential'],
+      categories: [],
       url: 'https://eslint.vuejs.org/rules/no-deprecated-delete-set.html'
     },
     fixable: null,
@@ -42,7 +43,7 @@ module.exports = {
     function getVueDeprecatedCallExpression(identifier, context) {
       // Instance API: this.$set()
       if (
-        DeprecatedDollarApis.has(identifier.name) &&
+        deprecatedDollarApis.has(identifier.name) &&
         identifier.parent.type === 'MemberExpression' &&
         utils.isThis(identifier.parent.object, context) &&
         identifier.parent.parent.type === 'CallExpression' &&
@@ -53,7 +54,7 @@ module.exports = {
 
       // Vue 2 Global API: Vue.set()
       if (
-        DeprecatedApis.includes(identifier.name) &&
+        deprecatedApis.includes(identifier.name) &&
         identifier.parent.type === 'MemberExpression' &&
         isVue(identifier.parent.object) &&
         identifier.parent.parent.type === 'CallExpression' &&
@@ -80,7 +81,7 @@ module.exports = {
             def.type === 'ImportBinding' &&
             def.node.type === 'ImportSpecifier' &&
             def.node.imported.type === 'Identifier' &&
-            DeprecatedApis.includes(def.node.imported.name) &&
+            deprecatedImportApis.has(def.node.imported.name) &&
             def.node.parent.type === 'ImportDeclaration' &&
             def.node.parent.source.value === 'vue'
           ) {
@@ -104,7 +105,7 @@ module.exports = {
               if (
                 prop.type === 'Property' &&
                 prop.key.type === 'Identifier' &&
-                DeprecatedApis.includes(prop.key.name) &&
+                deprecatedImportApis.has(prop.key.name) &&
                 prop.value.type === 'Identifier' &&
                 prop.value.name === identifier.name
               ) {
diff --git a/tests/lib/rules/no-deprecated-delete-set.js b/tests/lib/rules/no-deprecated-delete-set.js
index d13227cd3..60cee703a 100644
--- a/tests/lib/rules/no-deprecated-delete-set.js
+++ b/tests/lib/rules/no-deprecated-delete-set.js
@@ -20,6 +20,11 @@ tester.run('no-deprecated-delete-set', rule, {
     {
       filename: 'test.js',
       code: `
+        const another = function () {
+          this.$set(obj, key, value)
+          this.$delete(obj, key)
+        }
+
         createApp({
           mounted () {
             this.$emit('start')
@@ -33,18 +38,15 @@ tester.run('no-deprecated-delete-set', rule, {
       `
     },
     {
-      filename: 'test.js',
+      filename: 'test.vue',
       code: `
-        const another = function () {
-          this.$set(obj, key, value)
-          this.$delete(obj, key)
-        }
-
-        createApp({
-          mounted () {
-            this.$emit('start')
+        <script>
+          export default {
+            mounted () {
+              this.$nextTick()
+            }
           }
-        })
+        </script>
       `
     },
     {
@@ -104,10 +106,10 @@ tester.run('no-deprecated-delete-set', rule, {
       filename: 'test.vue',
       code: `
         <script>
-          const { nextTick: nt, provide: del } = require('vue')
+          const { nextTick: set, provide: del } = require('vue')
           export default {
             mounted () {
-              nt()
+              set()
               del(key, value)
             }
           }
@@ -218,7 +220,7 @@ tester.run('no-deprecated-delete-set', rule, {
       filename: 'test.vue',
       code: `
         <script>
-          import { set, delete as del } from 'vue'
+          import { set, del } from 'vue'
           export default {
             mounted () {
               set(obj, key, value)
@@ -242,7 +244,7 @@ tester.run('no-deprecated-delete-set', rule, {
       filename: 'test.vue',
       code: `
         <script setup>
-          import { set, delete as del } from 'vue'
+          import { set, del } from 'vue'
 
           set(obj, key, value)
           del(obj, key)
@@ -259,11 +261,32 @@ tester.run('no-deprecated-delete-set', rule, {
         }
       ]
     },
+    {
+      filename: 'test.vue',
+      code: `
+        <script setup>
+          import { set as s, del as d } from 'vue'
+
+          s(obj, key, value)
+          d(obj, key)
+        </script>
+      `,
+      errors: [
+        {
+          messageId: 'deprecated',
+          line: 5
+        },
+        {
+          messageId: 'deprecated',
+          line: 6
+        }
+      ]
+    },
     {
       filename: 'test.vue',
       code: `
         <script>
-          const { set, delete: del } = require('vue')
+          const { set, del } = require('vue')
           export default {
             mounted () {
               set(obj, key, value)
@@ -283,11 +306,35 @@ tester.run('no-deprecated-delete-set', rule, {
         }
       ]
     },
+    {
+      filename: 'test.vue',
+      code: `
+        <script>
+          const { set: s, del: d } = require('vue')
+          export default {
+            mounted () {
+              s(obj, key, value)
+              d(obj, key)
+            }
+          }
+        </script>
+      `,
+      errors: [
+        {
+          messageId: 'deprecated',
+          line: 6
+        },
+        {
+          messageId: 'deprecated',
+          line: 7
+        }
+      ]
+    },
     {
       filename: 'test.vue',
       code: `
         <script setup>
-          const { set, delete: del } = require('vue')
+          const { set, del } = require('vue')
 
           set(obj, key, value)
           del(obj, key)

From 4a4ad4b3f4448b453baf01ff53d3b36a8afb2947 Mon Sep 17 00:00:00 2001
From: waynzh <waynzh19@gmail.com>
Date: Fri, 30 Aug 2024 17:09:48 +0800
Subject: [PATCH 3/6] feat: update category

---
 docs/rules/index.md                   | 1 +
 lib/rules/no-deprecated-delete-set.js | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/docs/rules/index.md b/docs/rules/index.md
index 113ff416b..c5efced00 100644
--- a/docs/rules/index.md
+++ b/docs/rules/index.md
@@ -228,6 +228,7 @@ For example:
 | [vue/next-tick-style](./next-tick-style.md) | enforce Promise or callback style in `nextTick` | :wrench: | :hammer: |
 | [vue/no-bare-strings-in-template](./no-bare-strings-in-template.md) | disallow the use of bare strings in `<template>` |  | :hammer: |
 | [vue/no-boolean-default](./no-boolean-default.md) | disallow boolean defaults |  | :hammer: |
+| [vue/no-deprecated-delete-set](./no-deprecated-delete-set.md) | disallow using deprecated `$delete` and `$set` (in Vue.js 3.0.0+) |  | :warning: |
 | [vue/no-deprecated-model-definition](./no-deprecated-model-definition.md) | disallow deprecated `model` definition (in Vue.js 3.0.0+) | :bulb: | :warning: |
 | [vue/no-duplicate-attr-inheritance](./no-duplicate-attr-inheritance.md) | enforce `inheritAttrs` to be set to `false` when using `v-bind="$attrs"` |  | :hammer: |
 | [vue/no-empty-component-block](./no-empty-component-block.md) | disallow the `<template>` `<script>` `<style>` block to be empty |  | :hammer: |
diff --git a/lib/rules/no-deprecated-delete-set.js b/lib/rules/no-deprecated-delete-set.js
index db7724b4e..df604f269 100644
--- a/lib/rules/no-deprecated-delete-set.js
+++ b/lib/rules/no-deprecated-delete-set.js
@@ -24,7 +24,7 @@ module.exports = {
     docs: {
       description:
         'disallow using deprecated `$delete` and `$set` (in Vue.js 3.0.0+)',
-      categories: [],
+      categories: undefined,
       url: 'https://eslint.vuejs.org/rules/no-deprecated-delete-set.html'
     },
     fixable: null,

From ce2d8d522bbc6ebbacd00bb5686c1ed7b7d5b238 Mon Sep 17 00:00:00 2001
From: waynzh <waynzh19@gmail.com>
Date: Fri, 30 Aug 2024 17:18:58 +0800
Subject: [PATCH 4/6] feat: update set

---
 lib/rules/no-deprecated-delete-set.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/rules/no-deprecated-delete-set.js b/lib/rules/no-deprecated-delete-set.js
index df604f269..6c83a9c60 100644
--- a/lib/rules/no-deprecated-delete-set.js
+++ b/lib/rules/no-deprecated-delete-set.js
@@ -7,9 +7,9 @@
 const utils = require('../utils')
 const { findVariable } = require('@eslint-community/eslint-utils')
 
-const deprecatedApis = ['set', 'delete']
+const deprecatedApis = new Set(['set', 'delete'])
 const deprecatedImportApis = new Set(['set', 'del'])
-const deprecatedDollarApis = new Set(deprecatedApis.map((item) => `$${item}`))
+const deprecatedDollarApis = new Set(['$set', '$delete'])
 
 /**
  * @param {Expression|Super} node
@@ -54,7 +54,7 @@ module.exports = {
 
       // Vue 2 Global API: Vue.set()
       if (
-        deprecatedApis.includes(identifier.name) &&
+        deprecatedApis.has(identifier.name) &&
         identifier.parent.type === 'MemberExpression' &&
         isVue(identifier.parent.object) &&
         identifier.parent.parent.type === 'CallExpression' &&

From 85043f337cbfa7e0ebd58629bee0a5e8d7cf40a0 Mon Sep 17 00:00:00 2001
From: waynzh <waynzh19@gmail.com>
Date: Wed, 11 Sep 2024 15:34:15 +0800
Subject: [PATCH 5/6] feat: use ReferenceTracker

---
 lib/rules/no-deprecated-delete-set.js       | 108 ++++++++++----------
 tests/lib/rules/no-deprecated-delete-set.js |  26 ++++-
 2 files changed, 77 insertions(+), 57 deletions(-)

diff --git a/lib/rules/no-deprecated-delete-set.js b/lib/rules/no-deprecated-delete-set.js
index 6c83a9c60..873654976 100644
--- a/lib/rules/no-deprecated-delete-set.js
+++ b/lib/rules/no-deprecated-delete-set.js
@@ -5,10 +5,22 @@
 'use strict'
 
 const utils = require('../utils')
-const { findVariable } = require('@eslint-community/eslint-utils')
+const { ReferenceTracker } = require('@eslint-community/eslint-utils')
 
+/**
+ * @typedef {import('@eslint-community/eslint-utils').TYPES.TraceMap} TraceMap
+ */
+
+/** @type {TraceMap} */
+const deletedImportApisMap = {
+  set: {
+    [ReferenceTracker.CALL]: true
+  },
+  del: {
+    [ReferenceTracker.CALL]: true
+  }
+}
 const deprecatedApis = new Set(['set', 'delete'])
-const deprecatedImportApis = new Set(['set', 'del'])
 const deprecatedDollarApis = new Set(['$set', '$delete'])
 
 /**
@@ -63,59 +75,6 @@ module.exports = {
         return identifier.parent.parent
       }
 
-      // Vue 3 Global API
-      if (
-        identifier.parent.type === 'CallExpression' &&
-        identifier.parent.callee === identifier
-      ) {
-        const variable = findVariable(
-          utils.getScope(context, identifier),
-          identifier
-        )
-
-        if (variable != null && variable.defs.length === 1) {
-          const def = variable.defs[0]
-
-          // import { set as st } from 'vue'; st()
-          if (
-            def.type === 'ImportBinding' &&
-            def.node.type === 'ImportSpecifier' &&
-            def.node.imported.type === 'Identifier' &&
-            deprecatedImportApis.has(def.node.imported.name) &&
-            def.node.parent.type === 'ImportDeclaration' &&
-            def.node.parent.source.value === 'vue'
-          ) {
-            return identifier.parent
-          }
-
-          // const { set, delete } = require('vue'); set()
-          if (
-            def.type === 'Variable' &&
-            def.node.type === 'VariableDeclarator' &&
-            def.node.id.type === 'ObjectPattern' &&
-            def.node.init?.type === 'CallExpression' &&
-            def.node.init.callee.type === 'Identifier' &&
-            def.node.init.callee.name === 'require' &&
-            def.node.init.arguments.length === 1 &&
-            def.node.init.arguments[0].type === 'Literal' &&
-            def.node.init.arguments[0].value === 'vue'
-          ) {
-            const properties = def.node.id.properties
-            for (const prop of properties) {
-              if (
-                prop.type === 'Property' &&
-                prop.key.type === 'Identifier' &&
-                deprecatedImportApis.has(prop.key.name) &&
-                prop.value.type === 'Identifier' &&
-                prop.value.name === identifier.name
-              ) {
-                return identifier.parent
-              }
-            }
-          }
-        }
-      }
-
       return undefined
     }
 
@@ -136,7 +95,44 @@ module.exports = {
 
     return utils.compositingVisitors(
       utils.defineVueVisitor(context, nodeVisitor),
-      utils.defineScriptSetupVisitor(context, nodeVisitor)
+      utils.defineScriptSetupVisitor(context, nodeVisitor),
+      {
+        /** @param {Program} node */
+        Program(node) {
+          const tracker = new ReferenceTracker(utils.getScope(context, node))
+
+          // import { set } from 'vue'; set()
+          const esmTraceMap = {
+            vue: {
+              [ReferenceTracker.ESM]: true,
+              ...deletedImportApisMap
+            }
+          }
+
+          for (const { node } of tracker.iterateEsmReferences(esmTraceMap)) {
+            const refNode = /** @type {CallExpression} */ (node)
+            context.report({
+              node: refNode.callee,
+              messageId: 'deprecated'
+            })
+          }
+
+          // const { set } = require('vue'); set()
+          const cjsTraceMap = {
+            vue: {
+              ...deletedImportApisMap
+            }
+          }
+
+          for (const { node } of tracker.iterateCjsReferences(cjsTraceMap)) {
+            const refNode = /** @type {CallExpression} */ (node)
+            context.report({
+              node: refNode.callee,
+              messageId: 'deprecated'
+            })
+          }
+        }
+      }
     )
   }
 }
diff --git a/tests/lib/rules/no-deprecated-delete-set.js b/tests/lib/rules/no-deprecated-delete-set.js
index 60cee703a..a38b6ecea 100644
--- a/tests/lib/rules/no-deprecated-delete-set.js
+++ b/tests/lib/rules/no-deprecated-delete-set.js
@@ -11,7 +11,10 @@ const tester = new RuleTester({
   languageOptions: {
     parser: require('vue-eslint-parser'),
     ecmaVersion: 2020,
-    sourceType: 'module'
+    sourceType: 'module',
+    globals: {
+      require: 'readonly'
+    }
   }
 })
 
@@ -350,6 +353,27 @@ tester.run('no-deprecated-delete-set', rule, {
           line: 6
         }
       ]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <script setup>
+          const v = require('vue')
+
+          v.set(obj, key, value)
+          v.del(obj, key)
+        </script>
+      `,
+      errors: [
+        {
+          messageId: 'deprecated',
+          line: 5
+        },
+        {
+          messageId: 'deprecated',
+          line: 6
+        }
+      ]
     }
   ]
 })

From 9bbf8b8ee1b5f6c72573c2b9c48f4aa11c9fc027 Mon Sep 17 00:00:00 2001
From: waynzh <waynzh19@gmail.com>
Date: Wed, 11 Sep 2024 19:25:03 +0800
Subject: [PATCH 6/6] refactor

---
 lib/rules/no-deprecated-delete-set.js | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/lib/rules/no-deprecated-delete-set.js b/lib/rules/no-deprecated-delete-set.js
index 873654976..305dacf91 100644
--- a/lib/rules/no-deprecated-delete-set.js
+++ b/lib/rules/no-deprecated-delete-set.js
@@ -108,15 +108,6 @@ module.exports = {
               ...deletedImportApisMap
             }
           }
-
-          for (const { node } of tracker.iterateEsmReferences(esmTraceMap)) {
-            const refNode = /** @type {CallExpression} */ (node)
-            context.report({
-              node: refNode.callee,
-              messageId: 'deprecated'
-            })
-          }
-
           // const { set } = require('vue'); set()
           const cjsTraceMap = {
             vue: {
@@ -124,7 +115,10 @@ module.exports = {
             }
           }
 
-          for (const { node } of tracker.iterateCjsReferences(cjsTraceMap)) {
+          for (const { node } of [
+            ...tracker.iterateEsmReferences(esmTraceMap),
+            ...tracker.iterateCjsReferences(cjsTraceMap)
+          ]) {
             const refNode = /** @type {CallExpression} */ (node)
             context.report({
               node: refNode.callee,