-
-
Notifications
You must be signed in to change notification settings - Fork 688
test(no-deprecated-slot-attribute): make tests more strict #2793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(no-deprecated-slot-attribute): make tests more strict #2793
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Better test coverage is always appreciated 🙂
Thank you!
Continuation of #2773 (comment)
This PR converts all error assertions for
no-deprecated-slot-attribute
to include both error message and full location checks.Is this kind of PR appreciated? If not, we can close it. If yes, I will create one for each rule one at a time.