fix(nuxt): mark compatibility for nuxt v4 stable #3009
Conversation
✅ Deploy Preview for pinia-official canceled.
|
packages/nuxt/src/module.ts
Outdated
| @@ -27,7 +27,7 @@ const module: NuxtModule<ModuleOptions> = defineNuxtModule<ModuleOptions>({ | |||
| name: 'pinia', | |||
| configKey: 'pinia', | |||
| compatibility: { | |||
| nuxt: '^3.15.0 || ^4.0.0-0', | |||
| nuxt: '^3.15.0 || ^4.0.0-0 || ^4.0.0', | |||
There was a problem hiding this comment.
Thanks! This might be a bug in the semver check instead: https://jubianchi.github.io/semver-check/#/^4.0.0-0/4.0.0
There was a problem hiding this comment.
It seems like we can simplify it further even
https://jubianchi.github.io/semver-check/#/^4.0.0/4.0.0-alpha
There was a problem hiding this comment.
Interesting! That didn't use to be the case with npm 👀
There was a problem hiding this comment.
Indeed it is! But at least its a simpler syntax, so no harm in adopting it =)
There was a problem hiding this comment.
This is really strange that it works because 4.0.0-alpha is clearly behind a 4.0.0 release and ^ means 'after' on the second and third digit.
There was a problem hiding this comment.
@Barbapapazes in that case, could it actually be a display error on semver's end? I guess we should support stable releases more than alpha pre-releases, but maybe in order to support both we would need to combine the previous compatibility string with this PR's?
There was a problem hiding this comment.
The current version with just the stable is fine
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #3009 +/- ##
=======================================
Coverage 91.33% 91.33%
=======================================
Files 17 17
Lines 1397 1397
Branches 211 211
=======================================
Hits 1276 1276
Misses 120 120
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Resolves #3008
Nuxt v4 (the non-alpha version) has a version that the current compatibility string doesn't capture. This adds the new stable version to the compatibility string (we may want to combine the 2 v4 strings)