perf(blog): use string replace and flatMap if possible (#600)

Author: Mister-Hope

plugins/blog/plugin-blog/src/node/blogPlugin.ts

@@ -69,8 +69,8 @@ export const blogPlugin =
       type = [],
       slugify = (name: string): string =>
         name
-          .replace(/[ _]/g, '-')
-          .replace(/[:?*|\\/<>]/g, '')
+          .replaceAll(/[ _]/g, '-')
+          .replaceAll(/[:?*|\\/<>]/g, '')
           .toLowerCase(),
     } = options
 
@@ -170,8 +170,8 @@ export const blogPlugin =
           ...categoryResult.pageOptions,
           ...typeResult.pageOptions,
         ].map((page) => page.path!)
-        categoriesMap = categoryResult.categoriesMap
-        typesMap = typeResult.typesMap
+        ;({ categoriesMap } = categoryResult)
+        ;({ typesMap } = typeResult)
       },
 
       onPrepared: async (): Promise<void> => {
@@ -232,7 +232,7 @@ export const blogPlugin =
             )
 
             // add new pages
-            if (pagesToBeAdded.length) {
+            if (pagesToBeAdded.length > 0) {
               if (app.env.isDebug)
                 logger.info(
                   `Adding new pages: ${pagesToBeAdded.map(({ path }) => path).join(', ')}`,
@@ -251,7 +251,7 @@ export const blogPlugin =
             }
 
             // Remove pages
-            if (pagesToBeRemoved.length) {
+            if (pagesToBeRemoved.length > 0) {
               if (app.env.isDebug)
                 logger.info(
                   `Removing following pages: ${pagesToBeRemoved.join(', ')}`,
@@ -266,7 +266,7 @@ export const blogPlugin =
             }
 
             // Prepare pages entry
-            if (pagesToBeRemoved.length || pagesToBeAdded.length) {
+            if (pagesToBeRemoved.length > 0 || pagesToBeAdded.length > 0) {
               await prepareRoutes(app)
             }
 

plugins/blog/plugin-blog/src/node/category/getCategory.ts

@@ -45,8 +45,8 @@ export const getCategory = (
         : isString(itemPathOptions)
           ? (name: string): string =>
               itemPathOptions
-                .replace(/:key/g, slugify(key))
-                .replace(/:name/g, slugify(name))
+                .replaceAll(':key', slugify(key))
+                .replaceAll(':name', slugify(name))
           : (): null => null
 
       const categoryMap: CategoryMap = {}
@@ -55,7 +55,7 @@ export const getCategory = (
       for (const localePath in pagesMap) {
         if (path) {
           const pagePath = `${localePath}${removeLeadingSlash(
-            path.replace(/:key/g, slugify(key)),
+            path.replaceAll(':key', slugify(key)),
           )}`
 
           pageOptions.push({
@@ -159,6 +159,6 @@ export const getCategory = (
     categoriesMap: fromEntries(
       result.map(({ key, categoryMap }) => [key, categoryMap]),
     ),
-    pageOptions: result.map(({ pageOptions }) => pageOptions).flat(),
+    pageOptions: result.flatMap(({ pageOptions }) => pageOptions),
   }
 }

plugins/blog/plugin-blog/src/node/type/getType.ts

@@ -36,7 +36,7 @@ export const getType = (
         // get type page path
         const pagePath = path
           ? `${localePath}${removeLeadingSlash(
-              path.replace(/:key/g, slugify(key)),
+              path.replaceAll(':key', slugify(key)),
             )}`
           : ''
 
@@ -76,6 +76,6 @@ export const getType = (
 
   return {
     typesMap: fromEntries(result.map(({ key, typeMap }) => [key, typeMap])),
-    pageOptions: result.map(({ pageOptions }) => pageOptions).flat(),
+    pageOptions: result.flatMap(({ pageOptions }) => pageOptions),
   }
 }