Skip to content

fix[tool]: relax validation of solc json paths#4553

Draft
charles-cooper wants to merge 3 commits intovyperlang:masterfrom
charles-cooper:fix/path-collisions
Draft

fix[tool]: relax validation of solc json paths#4553
charles-cooper wants to merge 3 commits intovyperlang:masterfrom
charles-cooper:fix/path-collisions

Conversation

@charles-cooper
Copy link
Copy Markdown
Member

@charles-cooper charles-cooper commented Apr 3, 2025

allow multiple paths with different stems

fixes #4591

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

allow multiple paths with different stems
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.87%. Comparing base (d8532be) to head (29cff17).
⚠️ Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
vyper/cli/vyper_json.py 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4553      +/-   ##
==========================================
- Coverage   91.87%   91.87%   -0.01%     
==========================================
  Files         184      184              
  Lines       26907    26907              
  Branches     4687     4687              
==========================================
- Hits        24722    24720       -2     
- Misses       1478     1479       +1     
- Partials      707      708       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charles-cooper charles-cooper changed the title fix[cli]: relax validation of solc json inputs fix[tool]: relax validation of solc json paths Jun 17, 2025
@charles-cooper charles-cooper added the release - tentative items still being considered for release inclusion label Jun 17, 2025
@charles-cooper charles-cooper added this to the v0.4.4 milestone Jun 17, 2025
@github-actions
Copy link
Copy Markdown

📊 Bytecode Size Changes (venom)

No changes detected.

Full bytecode sizes

Contract legacy-O2 legacy-Os -O2 -O3 -Os
curvefi/amm/stableswap/meta_implementation/meta_implementation_v_700.vy 23610 22805 21162 20129 19688
curvefi/legacy/CurveStableSwapMetaNG.vy 24952 23578 20928 20309 19610
curvefi/amm/stableswap/implementation/implementation_v_700.vy 24962 23769 20657 19789 19235
curvefi/legacy/CurveStableSwapNG.vy 24473 23298 20047 19203 18681
curvefi/amm/tricryptoswap/implementation/implementation_v_200.vy 20590 19825 18346 17814 17259
yearnfi/VaultV3.vy 19972 19063 17162 15247 14589
curvefi/amm/twocryptoswap/implementation/implementation_v_210.vy 18090 17350 16558 15908 15427
curvefi/legacy/CurveCryptoSwap2.vy 18947 18382 15827 15274 14901
yearnfi/VaultV2.vy 16676 15763 14224 13737 12902
curvefi/amm/stableswap/factory/factory_v_100.vy 14558 13978 13639 12195 12185
curvefi/amm/stableswap/views/views_v_120.vy 12784 12368 10622 9986 10121
curvefi/gauge/child_gauge/implementation/implementation_v_110.vy 12338 11561 10484 9993 9393
curvefi/gauge/child_gauge/implementation/implementation_v_100.vy 12017 11249 10190 9700 9109
curvefi/amm/tricryptoswap/math/math_v_200.vy 11055 10992 9560 8176 8436
curvefi/legacy/CurveCryptoMathOptimized3.vy 11054 10991 9559 8176 8436
curvefi/gauge/child_gauge/implementation/implementation_v_020.vy 10665 9947 9223 8735 8205
curvefi/helpers/router/router_v_110.vy 6717 6717 7171 6517 6745
curvefi/amm/tricryptoswap/views/views_v_200.vy 7821 7776 7081 6797 6865
curvefi/registries/metaregistry/metaregistry_v_110.vy 7590 6732 7043 6186 6086
curvefi/helpers/stable_swap_meta_zap/stable_swap_meta_zap_v_100.vy 7302 7067 6782 6386 6484
curvefi/amm/twocryptoswap/views/views_v_200.vy 6991 6946 6537 6262 6321
curvefi/registries/metaregistry/registry_handlers/stableswap/handler_v_110.vy 6633 6259 6286 5451 5926
curvefi/amm/tricryptoswap/factory/factory_v_200.vy 5246 5021 5943 4950 5047
curvefi/amm/twocryptoswap/factory/factory_v_200.vy 5540 5252 5924 4662 4815
curvefi/amm/twocryptoswap/math/math_v_210.vy 6666 6666 5580 5098 5101
curvefi/gauge/child_gauge/factory/factory_v_201.vy 4844 4547 4293 4071 3834
curvefi/registries/metaregistry/registry_handlers/tricryptoswap/handler_v_110.vy 4241 3939 4089 3760 3765
curvefi/registries/metaregistry/registry_handlers/twocryptoswap/handler_v_110.vy 4186 3884 4020 3622 3643
yearnfi/VaultFactory.vy 3765 3617 3957 2484 2936
curvefi/gauge/child_gauge/factory/factory_v_100.vy 4183 3914 3714 3478 3260
curvefi/registries/address_provider/address_provider_v_201.vy 2973 2782 2905 2671 2523
curvefi/helpers/rate_provider/rate_provider_v_101.vy 3260 3260 2888 2516 2529
curvefi/amm/stableswap/math/math_v_100.vy 3067 3046 2656 2431 2448
curvefi/helpers/rate_provider/rate_provider_v_100.vy 2847 2841 2477 2140 2148
curvefi/helpers/deposit_and_stake_zap/deposit_and_stake_zap_v_100.vy 2322 2316 2197 1934 1965
curvefi/governance/relayer/taiko/relayer_v_001.vy 2068 2064 1718 1573 1603
curvefi/governance/relayer/polygon_cdk/relayer_v_101.vy 1556 1523 1516 1394 1392
curvefi/governance/relayer/arb_orbit/relayer_v_101.vy 1266 1262 1214 1118 1146
curvefi/governance/relayer/op_stack/relayer_v_101.vy 1186 1182 1147 1054 1079
curvefi/governance/relayer/not_rollup/relayer_v_100.vy 1168 1153 1136 1049 1058
curvefi/governance/vault/vault_v_100.vy 964 941 951 902 897
curvefi/governance/agent/agent_v_100.vy 541 541 497 439 443
curvefi/governance/agent/agent_v_101.vy 541 541 497 439 443
curvefi/governance/relayer/relayer_v_100.vy 496 496 468 463 468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release - tentative items still being considered for release inclusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix namespace collisions in solc_json

1 participant