-
Notifications
You must be signed in to change notification settings - Fork 30
feat: #192 add severity levels that are not violations #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bergos
wants to merge
3
commits into
gh-pages
Choose a base branch
from
issue-192-severity-levels
base: gh-pages
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| @prefix dash: <http://datashapes.org/dash#> . | ||
| @prefix ex: <http://example.com/ns#> . | ||
| @prefix mf: <http://www.w3.org/2001/sw/DataAccess/tests/test-manifest#> . | ||
| @prefix owl: <http://www.w3.org/2002/07/owl#> . | ||
| @prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> . | ||
| @prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> . | ||
| @prefix sh: <http://www.w3.org/ns/shacl#> . | ||
| @prefix sht: <http://www.w3.org/ns/shacl-test#> . | ||
| @prefix xsd: <http://www.w3.org/2001/XMLSchema#> . | ||
|
|
||
| ex:TestShape | ||
| rdf:type sh:NodeShape ; | ||
| sh:datatype xsd:integer ; | ||
| sh:severity sh:Debug ; | ||
| sh:targetNode "Hello" ; | ||
| . | ||
| <> | ||
| rdf:type mf:Manifest ; | ||
| mf:entries ( | ||
| <severity-004> | ||
| ) ; | ||
| . | ||
| <severity-004> | ||
| rdf:type sht:Validate ; | ||
| rdfs:label "Test of sh:severity sh:Debug 004" ; | ||
| mf:action [ | ||
| sht:dataGraph <> ; | ||
| sht:shapesGraph <> ; | ||
| ] ; | ||
| mf:result [ | ||
| rdf:type sh:ValidationReport ; | ||
| sh:conforms "true"^^xsd:boolean ; | ||
| sh:result [ | ||
| rdf:type sh:ValidationResult ; | ||
| sh:focusNode "Hello" ; | ||
| sh:resultSeverity sh:Debug ; | ||
| sh:sourceConstraintComponent sh:DatatypeConstraintComponent ; | ||
| sh:sourceShape ex:TestShape ; | ||
| sh:value "Hello" ; | ||
| ] ; | ||
| ] ; | ||
| mf:status sht:approved ; | ||
| . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| @prefix dash: <http://datashapes.org/dash#> . | ||
| @prefix ex: <http://example.com/ns#> . | ||
| @prefix mf: <http://www.w3.org/2001/sw/DataAccess/tests/test-manifest#> . | ||
| @prefix owl: <http://www.w3.org/2002/07/owl#> . | ||
| @prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> . | ||
| @prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> . | ||
| @prefix sh: <http://www.w3.org/ns/shacl#> . | ||
| @prefix sht: <http://www.w3.org/ns/shacl-test#> . | ||
| @prefix xsd: <http://www.w3.org/2001/XMLSchema#> . | ||
|
|
||
| ex:TestShape | ||
| rdf:type sh:NodeShape ; | ||
| sh:datatype xsd:integer ; | ||
| sh:severity sh:Trace ; | ||
| sh:targetNode "Hello" ; | ||
| . | ||
| <> | ||
| rdf:type mf:Manifest ; | ||
| mf:entries ( | ||
| <severity-005> | ||
| ) ; | ||
| . | ||
| <severity-005> | ||
| rdf:type sht:Validate ; | ||
| rdfs:label "Test of sh:severity sh:Trace 005" ; | ||
| mf:action [ | ||
| sht:dataGraph <> ; | ||
| sht:shapesGraph <> ; | ||
| ] ; | ||
| mf:result [ | ||
| rdf:type sh:ValidationReport ; | ||
| sh:conforms "true"^^xsd:boolean ; | ||
| sh:result [ | ||
| rdf:type sh:ValidationResult ; | ||
| sh:focusNode "Hello" ; | ||
| sh:resultSeverity sh:Trace ; | ||
| sh:sourceConstraintComponent sh:DatatypeConstraintComponent ; | ||
| sh:sourceShape ex:TestShape ; | ||
| sh:value "Hello" ; | ||
| ] ; | ||
| ] ; | ||
| mf:status sht:approved ; | ||
| . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think my one last hangup on this PR is this escape and the lack of demonstration of a "test configuration record".
The tests @bergos added, 4 and 5, are fine demonstrations of a validation result set with conformance of
trueand the non-violation levels. (Thank you, Thomas.)Can the test suite support a new test 6, mostly duplicative of 4 or 5, but instead using
sh:Warningand a conformance oftrue? How would test suite conformance be reproducible?I feel like another property in the
ValidationReportwould be helpful, that logs whether itssh:conformancevalue was set to "excuse"sh:Infoorsh:Warningseverity results from trippingsh:conformanceintofalse.[] a sh:ValidationReport ; sh:excuses sh:Warning ; ...?sh:permits,sh:permitsSeverity, orsh:excusesSeveritymight work too.