-
Notifications
You must be signed in to change notification settings - Fork 30
Issue 414: list constraints #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/memberShape
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you have linked the new constraint parameters to the same constraint component for memberShape. I believe it would be better to introduce separate constraint components for each of them. It makes the definition more modular but, more importantly, it is perfectly sensible to use for example sh:minListLength without a sh:memberShape constraint.
This comment was marked as resolved.
This comment was marked as resolved.
I wouldn't worry too much about malformed lists. Usually people use tools to produce them, including editing TTL source code. So if they are reported twice, this shouldn't be the end of the world. |
I also saw a comment about lists not being valid objects of |
Yeah my fault. I deleted the comment because I understood later what you did. |
…ListLength, sh:uniqueMembers separate constraint components
536ce96
to
2133631
Compare
I think this is good to go now - I suggest we merge this to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am in the middle of implementing all this in Java and found various issues.
I have addressed the issues found - is there an(other?) open source implementation that'd be useful for me to implement the changes against (@bergos' JS shacl-engine perhaps) in case there are any more errors to catch. P.S. I am conferencing for the next 3 days so will be slow to respond |
Closes #414. This PR implements
sh:minListLength
,sh:maxListLength
andsh:uniqList
.My interpretation of the following from the definition of 2.1.1 Constraints, Parameters and Constraint Components is that because the
sh:MemberShapeConstraintComponent
now has multiple parameters; there can only be one occurrence ofsh:memberShape
in a given shape - and I have updated thesh:maxCount
accordingly.This is currently targeted to #403 branch for a smaller diff in the GH UI. #403 should be merged and this targeted to
gh-pages
rather than merging this branch into #403