-
Notifications
You must be signed in to change notification settings - Fork 4
Suggestions from January review on §3.4 #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Bob DuCharme's 9th comment https://www.w3.org/mid/33e6564c-0dc3-4ca6-8304-4e47da867bf6@snee.com
Bob DuCharme's 11th comment https://www.w3.org/mid/33e6564c-0dc3-4ca6-8304-4e47da867bf6@snee.com
@@ -791,7 +791,7 @@ <h3>Literals</h3> | |||
<p>Literals are used for values such as strings, numbers, and dates.</p> | |||
|
|||
<p>A <dfn data-local-lt="RDF literal">literal</dfn> in an <a>RDF graph</a> consists of | |||
two, three, or four elements, as follow:</p> | |||
two, three, or four component elements, as follows:</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggestion ("component elements" sounds a bit weird to me):
two, three, or four component elements, as follows:</p> | |
two, three, or four components, as follows:</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small tweak.
two, three, or four components, as follow:</p>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TallTed the change from "as follow" to "as follows" was suggested by @bobdc, and makes sense to me because
- everywhere else, we use "as follows"
- my understanding, confirmed by a quick web search, is that "as follows" is grammatically correct, while "as follow" is not
Any argument in the defense of "as follow"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are differing opinions on this bit of grammar. To my ear, follow
sounds better after a plural antecedent. I think the best solution would be to change follow(s)
to below
, for which there is no belows
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"components" is also used as "The three components (s, p, o) of an RDF triple. "component element" is an attempt to distinguish the usage at this point then continue using "element" in the rest of the next. It leaves "element" in the rest of the section alone.
If its one word "component" here the rest of the section needs updating as well. "if the third element is present" etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for mentioning the rationale for this change @afs ! Yet, I would still prefer to use "components". "component element" sounds repetitive and clunky.
If its one word "component" here the rest of the section needs updating as well. "if the third element is present" etc.
There are three places in the whole document where the word "element" is used in the given context:
- Right after the four bullet points of the definition of "literal". Here it says: "[..] if the third element is present and the fourth element is not present. [..] if both the third element and fourth elements are present."
--> I propose to replace these mentions of "element" by the actual names of the elements: "[..] if the language tag is present and the base direction is not present. [..] if both the language tag and the base direction are present." - In the abstract, where it says: "RDF 1.2 also introduces directional language-tagged strings, which contain a base direction element that [..]"
--> I propose to replace this by: ".. contain a base direction component .." - In the change log (4-th bullet point), where it says: "Added the base direction element as part of [..]"
--> Also for this one, I propose to replace it by: ".. the base direction component .."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"component" is OK with those changes.
Co-authored-by: Olaf Hartig <olaf.hartig@liu.se>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with my additional suggested change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes for the component/element discussion.
Preview | Diff