-
Notifications
You must be signed in to change notification settings - Fork 24
add tests for rdfs:Proposition #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
link to these tests from Semantics when merged |
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#> | ||
PREFIX : <http://example.com/ns#> | ||
|
||
<<( :a :b :c )>> rdf:type rdfs:Proposition . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't valid. It either needs to be:
_:pp rdf:type rdfs:Proposition .
or, perhaps, change mf:entailmentRegime
to "RDFS-Plus"
and use:
_:pp rdf:type rdfs:Proposition .
_:pp owl:sameAs <<( :a :b :c )>> .
A more radical alternative is to use SPARQL ASK queries for the result specs; since SPARQL allows for symmetric patterns. I.e.:
ASK {
<<( :a :b :c )>> rdf:type rdfs:Proposition .
}
is valid. (I would be in favour of that and can do the changes if desired. Entailments don't need to be materialized, only true.)
Aside: There is no test for the entailed rdf:type
of literals. This should be added too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing to
:a1 :p1 _:pp .
_:pp rdf:type rdfs:Proposition .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since SPARQL allows for symmetric patterns.
Syntax wise, yes, but the matching is to an RDF graph, not a symmetric RDF graph, so it falls at that step (spec wise).
It would be a good idea to also check for entailment of literals if that is not currently done, but that should be the subject of a different issue or PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Proposal in #205. |
Co-authored-by: Niklas Lindström <lindstream@gmail.com>
No description provided.