Skip to content

chore: remove dist/ from git #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2021
Merged

chore: remove dist/ from git #562

merged 2 commits into from
Apr 8, 2021

Conversation

saschanaz
Copy link
Member

This patch closes #__ and includes:

  • A relevant test: N/A
  • A relevant documentation update: N/A, the npm package will still have it

@saschanaz saschanaz requested a review from marcoscaceres April 8, 2021 16:25
@saschanaz saschanaz merged commit aee5e6d into main Apr 8, 2021
@saschanaz saschanaz deleted the remove-dist branch April 8, 2021 22:46
@dontcallmedom
Copy link
Member

one used to be able to load webidl2.js from https://w3c.github.io/webidl2.js/dist/webidl2.js - is there a new equivalent or is that no longer supported?

@saschanaz
Copy link
Member Author

saschanaz commented Jun 22, 2021

one used to be able to load webidl2.js from https://w3c.github.io/webidl2.js/dist/webidl2.js - is there a new equivalent or is that no longer supported?

Didn't know someone is using it 👀

One can still use lib/webidl2.js but it's an ES module. Is it a viable option there?

@saschanaz
Copy link
Member Author

Or I wonder ReSpec can directly provide parsed IDLs for plugins. @sidvishnoi, do you have some thoughts?

@sidvishnoi
Copy link
Member

That could be supported via https://github.com/w3c/respec/pull/3320 (if). It would be more like exposing utils.webidl = WebIDL2 though.

Meanwhile, can import dist/ directly from npm instead of github (using unpkg or some other npm cdn):
https://unpkg.com/webidl2/dist/webidl2.js
https://unpkg.com/webidl2@24/dist/webidl2.js // semver

@saschanaz
Copy link
Member Author

saschanaz commented Jun 22, 2021

On a second thought I think it's not very good idea since any breaking change from webidl2.js would make breaking change in ReSpec.

@dontcallmedom
Copy link
Member

Meanwhile, can import dist/ directly from npm instead of github

thanks, that's the perfect solution to my need; it might be useful to document it in the README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants