Skip to content

Refactor to use maps.Keys #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Refactor to use maps.Keys #638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions dive/filetree/order_strategy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package filetree

import (
"maps"
"slices"
"sort"
)

Expand Down Expand Up @@ -30,10 +32,7 @@ func GetSortOrderStrategy(sortOrder SortOrder) OrderStrategy {
type orderByNameStrategy struct{}

func (orderByNameStrategy) orderKeys(files map[string]*FileNode) []string {
var keys []string
for key := range files {
keys = append(keys, key)
}
keys := slices.Collect(maps.Keys(files))

sort.Strings(keys)

Expand All @@ -43,10 +42,7 @@ func (orderByNameStrategy) orderKeys(files map[string]*FileNode) []string {
type orderBySizeDescStrategy struct{}

func (orderBySizeDescStrategy) orderKeys(files map[string]*FileNode) []string {
var keys []string
for key := range files {
keys = append(keys, key)
}
keys := slices.Collect(maps.Keys(files))

sort.Slice(keys, func(i, j int) bool {
ki, kj := keys[i], keys[j]
Expand Down