-
Notifications
You must be signed in to change notification settings - Fork 0
feat(radio): ラジオ・パターンを日本語に翻訳 #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: waic-main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for waic-apg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR translates the Radio Group pattern pages and related examples into Japanese and updates coverage metadata and report content to reflect the new titles and references.
- Localizes three radio-related HTML pages (pattern and two examples), including headings, instructional text, and ARIA labels.
- Updates coverage CSVs and the coverage report HTML to align counts, labels, and links with the translated content.
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 10 comments.
Show a summary per file
File | Description |
---|---|
content/patterns/radio/radio-group-pattern.html | Japanese translation of the Radio Group pattern documentation. |
content/patterns/radio/examples/radio.html | Japanese translation of the roving tabindex radio example, including UI strings and accessibility labels. |
content/patterns/radio/examples/radio-rating.html | Japanese translation of the rating radio example; updated example section content and labels. |
content/patterns/radio/examples/radio-activedescendant.html | Japanese translation of the aria-activedescendant radio example, including tables and accessibility notes. |
content/about/coverage-and-quality/role-coverage.csv | Synchronizes role coverage counts and example titles with translations. |
content/about/coverage-and-quality/prop-coverage.csv | Synchronizes property/state coverage references with translated example titles. |
content/about/coverage-and-quality/coverage-and-quality-report.html | Updates report counts and example names/links to match translations. |
Comments suppressed due to low confidence (1)
content/patterns/radio/examples/radio-activedescendant.html:1
- The preceding line refers to
aria--activedescendant
(double hyphen). Correct toaria-activedescendant
in the text to avoid confusion.
<!DOCTYPE html>
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
<li>フォーカスがラジオボタンにあり、そのラジオボタンがラジオグループの最後のラジオボタン**ではない**場合、フォーカスを次のラジオボタンに移動します。</li> | ||
<li>フォーカスがラジオグループの最後のラジオボタンにあり、そのラジオボタンがツールバーの最後の要素**ではない**場合、フォーカスをツールバーの次の要素に移動します。</li> | ||
<li>フォーカスがラジオグループの最後のラジオボタンにあり、そのラジオボタンがツールバーの最後の要素でもある場合、フォーカスをツールバーの最初の要素に移動します。</li> | ||
</ul> | ||
</li> | ||
<li> | ||
<kbd>Left Arrow</kbd>: | ||
<kbd>左矢印</kbd>: | ||
<ul> | ||
<li>When focus is on a radio button and that radio button is <strong>not</strong> the first radio button in the radio group, moves focus to the previous radio button.</li> | ||
<li>When focus is on the first radio button in the radio group and that radio button is <strong>not</strong> the first element in the toolbar, moves focus to the previous element in the toolbar.</li> | ||
<li>When focus is on the first radio button in the radio group and that radio button is also the first element in the toolbar, moves focus to the last element in the toolbar.</li> | ||
<li>フォーカスがラジオボタンにあり、そのラジオボタンがラジオグループの最初のラジオボタン**ではない**場合、フォーカスを前のラジオボタンに移動します。</li> | ||
<li>フォーカスがラジオグループの最初のラジオボタンにあり、そのラジオボタンがツールバーの最初の要素**ではない**場合、フォーカスをツールバーの前の要素に移動します。</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Markdown-style emphasis (ではない) will render literally in HTML. Replace with HTML emphasis to preserve styling, e.g., use ではない: 最後のラジオボタンではない, 最後の要素ではない.
Copilot uses AI. Check for mistakes.
<li>フォーカスがラジオボタンにあり、そのラジオボタンがラジオグループの最後のラジオボタン**ではない**場合、フォーカスを次のラジオボタンに移動します。</li> | ||
<li>フォーカスがラジオグループの最後のラジオボタンにあり、そのラジオボタンがツールバーの最後の要素**ではない**場合、フォーカスをツールバーの次の要素に移動します。</li> | ||
<li>フォーカスがラジオグループの最後のラジオボタンにあり、そのラジオボタンがツールバーの最後の要素でもある場合、フォーカスをツールバーの最初の要素に移動します。</li> | ||
</ul> | ||
</li> | ||
<li> | ||
<kbd>Left Arrow</kbd>: | ||
<kbd>左矢印</kbd>: | ||
<ul> | ||
<li>When focus is on a radio button and that radio button is <strong>not</strong> the first radio button in the radio group, moves focus to the previous radio button.</li> | ||
<li>When focus is on the first radio button in the radio group and that radio button is <strong>not</strong> the first element in the toolbar, moves focus to the previous element in the toolbar.</li> | ||
<li>When focus is on the first radio button in the radio group and that radio button is also the first element in the toolbar, moves focus to the last element in the toolbar.</li> | ||
<li>フォーカスがラジオボタンにあり、そのラジオボタンがラジオグループの最初のラジオボタン**ではない**場合、フォーカスを前のラジオボタンに移動します。</li> | ||
<li>フォーカスがラジオグループの最初のラジオボタンにあり、そのラジオボタンがツールバーの最初の要素**ではない**場合、フォーカスをツールバーの前の要素に移動します。</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The emphasis markers (ではない) are not valid HTML. Use semantic HTML emphasis: 最初のラジオボタンではない, 最初の要素ではない.
Copilot uses AI. Check for mistakes.
<p> | ||
このメーターの値は 5 秒ごとに変化します。 | ||
一時停止ボタンを使用して変更を停止します。 | ||
</p> | ||
<h3 id="cpu_usage_label">中央処理装置 (CPU) 使用率</h3> | ||
<p> | ||
<button type="button" class="play-meters">更新を一時停止</button> | ||
</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated “meter/CPU usage” content and a play-meters button were inserted into the radio rating example. This appears accidental and is not used by the example’s JavaScript; remove lines 52–60 so the section contains only the rating radio group content.
<p> | |
このメーターの値は 5 秒ごとに変化します。 | |
一時停止ボタンを使用して変更を停止します。 | |
</p> | |
<h3 id="cpu_usage_label">中央処理装置 (CPU) 使用率</h3> | |
<p> | |
<button type="button" class="play-meters">更新を一時停止</button> | |
</p> |
Copilot uses AI. Check for mistakes.
<p> | ||
このメーターの値は 5 秒ごとに変化します。 | ||
一時停止ボタンを使用して変更を停止します。 | ||
</p> | ||
<h3 id="cpu_usage_label">中央処理装置 (CPU) 使用率</h3> | ||
<p> | ||
<button type="button" class="play-meters">更新を一時停止</button> | ||
</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated “meter/CPU usage” content and a play-meters button were inserted into the radio rating example. This appears accidental and is not used by the example’s JavaScript; remove lines 52–60 so the section contains only the rating radio group content.
<p> | |
このメーターの値は 5 秒ごとに変化します。 | |
一時停止ボタンを使用して変更を停止します。 | |
</p> | |
<h3 id="cpu_usage_label">中央処理装置 (CPU) 使用率</h3> | |
<p> | |
<button type="button" class="play-meters">更新を一時停止</button> | |
</p> |
Copilot uses AI. Check for mistakes.
<h2 id="ex_label">例</h2> | ||
</div> | ||
<div role="separator" id="ex_start_sep" aria-labelledby="ex_start_sep ex_label" aria-label="Start of"></div> | ||
<div role="separator" id="ex_start_sep" aria-labelledby="ex_start_sep ex_label" aria-label="の開始"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For natural Japanese announcement order, swap aria-labelledby references so the accessible name becomes “例 の開始” (Example, start): aria-labelledby="ex_label ex_start_sep".
<div role="separator" id="ex_start_sep" aria-labelledby="ex_start_sep ex_label" aria-label="の開始"></div> | |
<div role="separator" id="ex_start_sep" aria-labelledby="ex_label ex_start_sep" aria-label="の開始"></div> |
Copilot uses AI. Check for mistakes.
</div> | ||
</div> | ||
<div role="separator" id="ex_end_sep" aria-labelledby="ex_end_sep ex_label" aria-label="End of"></div> | ||
<div role="separator" id="ex_end_sep" aria-labelledby="ex_end_sep ex_label" aria-label="の終了"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly, swap aria-labelledby order for a natural reading “例 の終了”: aria-labelledby="ex_label ex_end_sep".
<div role="separator" id="ex_end_sep" aria-labelledby="ex_end_sep ex_label" aria-label="の終了"></div> | |
<div role="separator" id="ex_end_sep" aria-labelledby="ex_label ex_end_sep" aria-label="の終了"></div> |
Copilot uses AI. Check for mistakes.
<h2 id="ex_label">例</h2> | ||
</div> | ||
<div role="separator" id="ex_start_sep" aria-labelledby="ex_start_sep ex_label" aria-label="Start of"></div> | ||
<div role="separator" id="ex_start_sep" aria-labelledby="ex_start_sep ex_label" aria-label="の開始"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swap aria-labelledby order so assistive tech reads “例 の開始”: aria-labelledby="ex_label ex_start_sep".
<div role="separator" id="ex_start_sep" aria-labelledby="ex_start_sep ex_label" aria-label="の開始"></div> | |
<div role="separator" id="ex_start_sep" aria-labelledby="ex_label ex_start_sep" aria-label="の開始"></div> |
Copilot uses AI. Check for mistakes.
</ul> | ||
</div> | ||
<div role="separator" id="ex_end_sep" aria-labelledby="ex_end_sep ex_label" aria-label="End of"></div> | ||
<div role="separator" id="ex_end_sep" aria-labelledby="ex_end_sep ex_label" aria-label="の終了"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swap aria-labelledby order to announce “例 の終了”: aria-labelledby="ex_label ex_end_sep".
<div role="separator" id="ex_end_sep" aria-labelledby="ex_end_sep ex_label" aria-label="の終了"></div> | |
<div role="separator" id="ex_end_sep" aria-labelledby="ex_label ex_end_sep" aria-label="の終了"></div> |
Copilot uses AI. Check for mistakes.
</div> | ||
<div role="separator" id="ex_start_sep" aria-labelledby="ex_start_sep ex_label" aria-label="Start of"></div> | ||
<div id="ex1"> | ||
<div role="separator" id="ex_start_sep" aria-labelledby="ex_start_sep ex_label" aria-label="の開始"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swap aria-labelledby order so the separator is announced as “例 の開始”: aria-labelledby="ex_label ex_start_sep".
<div role="separator" id="ex_start_sep" aria-labelledby="ex_start_sep ex_label" aria-label="の開始"></div> | |
<div role="separator" id="ex_start_sep" aria-labelledby="ex_label ex_start_sep" aria-label="の開始"></div> |
Copilot uses AI. Check for mistakes.
</div> | ||
</div> | ||
<div role="separator" id="ex_end_sep" aria-labelledby="ex_end_sep ex_label" aria-label="End of"></div> | ||
<div role="separator" id="ex_end_sep" aria-labelledby="ex_end_sep ex_label" aria-label="の終了"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swap aria-labelledby order so the separator is announced as “例 の終了”: aria-labelledby="ex_label ex_end_sep".
<div role="separator" id="ex_end_sep" aria-labelledby="ex_end_sep ex_label" aria-label="の終了"></div> | |
<div role="separator" id="ex_end_sep" aria-labelledby="ex_label ex_end_sep" aria-label="の終了"></div> |
Copilot uses AI. Check for mistakes.
関連Issue
レビュワーに見てもらいたい箇所
翻訳チェックリスト
html
要素にlang="ja"
属性を付与するh1
要素の直下に翻訳元リビジョンを記載する