Skip to content

Conversation

nishimotz
Copy link
Collaborator

レビュー用に以下の変更を行っている

  • id 440 以降にはレビュー作業中であることを注記
  • テスト結果を環境順ではなく結果IDの順に表示

@nishimotz
Copy link
Collaborator Author

判定のマルバツを選択する処理があやしい

@nishimotz
Copy link
Collaborator Author

現状 {item.judgment === '満たしている' ? '○' : '×'} としており、すでに が入っていたら '×' になってしまう。

@nishimotz nishimotz changed the title results id 440 to 580 テスト結果ID 440 から 580 の追加 Sep 11, 2024
Comment on lines +14 to +37
if: github.event.pull_request.merged == true || github.event_name == 'push' || github.event_name == 'pull_request'
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: プルリクエストの場合、PRブランチをチェックアウト
if: github.event_name == 'pull_request'
run: git checkout ${{ github.event.pull_request.head.sha }}

- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.x'

- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install pyyaml

- name: Run checkdata.py
run: python3 .github/workflows/checkdata.py

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

Copilot Autofix

AI about 1 month ago

To fix the problem, add a permissions block to the workflow file. The minimal required permission for this workflow is contents: read, which allows the workflow to check out code but does not grant unnecessary write access. The permissions block should be added at the top level of the workflow (just after the name: and before on:), so it applies to all jobs unless overridden. No other changes are needed, as the workflow does not appear to require any additional permissions.


Suggested changeset 1
.github/workflows/checkdata.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/checkdata.yml b/.github/workflows/checkdata.yml
--- a/.github/workflows/checkdata.yml
+++ b/.github/workflows/checkdata.yml
@@ -1,3 +1,5 @@
+permissions:
+  contents: read
 name: checkdata
 
 on:
EOF
@@ -1,3 +1,5 @@
permissions:
contents: read
name: checkdata

on:
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant