Skip to content

Commit e05fa69

Browse files
committed
fix(middleware): Update error handling logic to render custom messages
1 parent f70a07e commit e05fa69

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

src/middleware.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,10 @@ import { NextFunction, Request, Response } from 'express';
1414

1515
export function notFoundMiddleware() {
1616
return (req: Request, res: Response, next: NextFunction) => {
17-
throw NotFoundError();
17+
return res.status(404).render('error.html', {
18+
statusCode: 404,
19+
message: 'not found',
20+
});
1821
};
1922
}
2023

@@ -250,9 +253,9 @@ export function errorMiddleware() {
250253
logger.error(error);
251254
}
252255

253-
return res.status(error.statusCode || 500).render('error.html', {
254-
statusCode: error.statusCode || 500,
255-
message: error.message,
256+
return res.status(500).render('error.html', {
257+
statusCode: 500,
258+
message: appConfig.env !== 'production' ? error.stack : 'internal server error',
256259
});
257260
};
258261
}

0 commit comments

Comments
 (0)