Skip to content

A few improvements#4

Open
jimmyff wants to merge 2 commits into
wal33d006:masterfrom
jimmyff:master
Open

A few improvements#4
jimmyff wants to merge 2 commits into
wal33d006:masterfrom
jimmyff:master

Conversation

@jimmyff
Copy link
Copy Markdown

@jimmyff jimmyff commented Aug 24, 2020

This solves a few issues:

  1. SizedBox with height:30 made this unusable for small font sizes
  2. Changing the container height seemed like a strange way of doing an animation and wasn't working for me, maybe as I was using a really small font. Anyway -replacing this with Transform.translate is a more standard way of achieving this
  3. endTweenValue being fixed as 8 means that really small fonts had a huge animation and really big fonts had a small animation, now it's calculated based on fontSize
  4. Solved all of package:pedantic warnings & notices for this single file (I didn't do the whole project).

…rid of varying height Container for Transform.translate), solved all package:pedantic notices & warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant