test: update authorization resource tests

- Refactored and improved test cases in bastion/resource_authorization_test.go
- Fix after linting error

Author: bsimonWallix

bastion/resource_authorization_test.go

@@ -76,8 +76,22 @@ resource "wallix-bastion_authorization" "testacc_Authorization" {
   target_group       = wallix-bastion_targetgroup.testacc_Authorization.group_name
   authorize_sessions = true
   subprotocols = [
-    "RDP_CLIPBOARD_UP", "RDP_CLIPBOARD_DOWN", "RDP_PRINTER", "RDP_COM_PORT", "RDP_DRIVE", "RDP_SMARTCARD", "RDP_CLIPBOARD_FILE", "RDP_AUDIO_OUTPUT",
-    "SSH_SHELL_SESSION", "SSH_REMOTE_COMMAND", "SSH_SCP_UP", "SSH_SCP_DOWN", "SSH_X11", "SSH_DIRECT_TCPIP", "SSH_REVERSE_TCPIP", "SSH_AUTH_AGENT",
+    "RDP_CLIPBOARD_UP",
+    "RDP_CLIPBOARD_DOWN",
+    "RDP_PRINTER",
+    "RDP_COM_PORT",
+    "RDP_DRIVE",
+    "RDP_SMARTCARD",
+    "RDP_CLIPBOARD_FILE",
+    "RDP_AUDIO_OUTPUT",
+    "SSH_SHELL_SESSION",
+    "SSH_REMOTE_COMMAND",
+    "SSH_SCP_UP",
+    "SSH_SCP_DOWN",
+    "SSH_X11",
+    "SSH_DIRECT_TCPIP",
+    "SSH_REVERSE_TCPIP",
+    "SSH_AUTH_AGENT",
     "SFTP_SESSION",
     "RDP",
     "VNC",
@@ -86,10 +100,12 @@ resource "wallix-bastion_authorization" "testacc_Authorization" {
     "RAWTCPIP",
   ]
 }
+
 resource "wallix-bastion_usergroup" "testacc_Authorization" {
   group_name = "testacc_Authorization"
   timeframes = ["allthetime"]
 }
+
 resource "wallix-bastion_targetgroup" "testacc_Authorization" {
   group_name = "testacc_Authorization"
 }
@@ -108,8 +124,22 @@ resource "wallix-bastion_authorization" "testacc_Authorization" {
   authorize_session_sharing    = true
   session_sharing_mode         = "view_control"
   subprotocols = [
-    "RDP_CLIPBOARD_UP", "RDP_CLIPBOARD_DOWN", "RDP_PRINTER", "RDP_COM_PORT", "RDP_DRIVE", "RDP_SMARTCARD", "RDP_CLIPBOARD_FILE", "RDP_AUDIO_OUTPUT",
-    "SSH_SHELL_SESSION", "SSH_REMOTE_COMMAND", "SSH_SCP_UP", "SSH_SCP_DOWN", "SSH_X11", "SSH_DIRECT_TCPIP", "SSH_REVERSE_TCPIP", "SSH_AUTH_AGENT",
+    "RDP_CLIPBOARD_UP",
+    "RDP_CLIPBOARD_DOWN",
+    "RDP_PRINTER",
+    "RDP_COM_PORT",
+    "RDP_DRIVE",
+    "RDP_SMARTCARD",
+    "RDP_CLIPBOARD_FILE",
+    "RDP_AUDIO_OUTPUT",
+    "SSH_SHELL_SESSION",
+    "SSH_REMOTE_COMMAND",
+    "SSH_SCP_UP",
+    "SSH_SCP_DOWN",
+    "SSH_X11",
+    "SSH_DIRECT_TCPIP",
+    "SSH_REVERSE_TCPIP",
+    "SSH_AUTH_AGENT",
     "SFTP_SESSION",
     "RDP",
     "VNC",
@@ -130,14 +160,17 @@ resource "wallix-bastion_authorization" "testacc_Authorization" {
   mandatory_ticket  = true
   single_connection = true
 }
+
 resource "wallix-bastion_usergroup" "testacc_Authorization" {
   group_name = "testacc_Authorization"
   timeframes = ["allthetime"]
 }
+
 resource "wallix-bastion_usergroup" "testacc_Authorization2" {
   group_name = "testacc_Authorization2"
   timeframes = ["allthetime"]
 }
+
 resource "wallix-bastion_targetgroup" "testacc_Authorization" {
   group_name = "testacc_Authorization"
 }
@@ -149,20 +182,22 @@ func testAccResourceAuthorizationSessionSharingViewOnly() string {
 	return `
 resource "wallix-bastion_authorization" "testacc_Authorization_sharing" {
   authorization_name        = "testacc_Authorization_sharing"
-  user_group               = wallix-bastion_usergroup.testacc_Authorization_sharing.group_name
-  target_group             = wallix-bastion_targetgroup.testacc_Authorization_sharing.group_name
-  authorize_sessions       = true
+  user_group                = wallix-bastion_usergroup.testacc_Authorization_sharing.group_name
+  target_group              = wallix-bastion_targetgroup.testacc_Authorization_sharing.group_name
+  authorize_sessions        = true
   authorize_session_sharing = true
-  session_sharing_mode     = "view_only"
+  session_sharing_mode      = "view_only"
   subprotocols = [
     "RDP",
     "SSH_SHELL_SESSION",
   ]
 }
+
 resource "wallix-bastion_usergroup" "testacc_Authorization_sharing" {
   group_name = "testacc_Authorization_sharing"
   timeframes = ["allthetime"]
 }
+
 resource "wallix-bastion_targetgroup" "testacc_Authorization_sharing" {
   group_name = "testacc_Authorization_sharing"
 }
@@ -174,20 +209,22 @@ func testAccResourceAuthorizationSessionSharingViewControl() string {
 	return `
 resource "wallix-bastion_authorization" "testacc_Authorization_sharing" {
   authorization_name        = "testacc_Authorization_sharing"
-  user_group               = wallix-bastion_usergroup.testacc_Authorization_sharing.group_name
-  target_group             = wallix-bastion_targetgroup.testacc_Authorization_sharing.group_name
-  authorize_sessions       = true
+  user_group                = wallix-bastion_usergroup.testacc_Authorization_sharing.group_name
+  target_group              = wallix-bastion_targetgroup.testacc_Authorization_sharing.group_name
+  authorize_sessions        = true
   authorize_session_sharing = true
-  session_sharing_mode     = "view_control"
+  session_sharing_mode      = "view_control"
   subprotocols = [
     "RDP",
     "SSH_SHELL_SESSION",
   ]
 }
+
 resource "wallix-bastion_usergroup" "testacc_Authorization_sharing" {
   group_name = "testacc_Authorization_sharing"
   timeframes = ["allthetime"]
 }
+
 resource "wallix-bastion_targetgroup" "testacc_Authorization_sharing" {
   group_name = "testacc_Authorization_sharing"
 }