Open
Conversation
When --setup is given a file which is not in the current directory, it fails with an attribute error "None has no attribute group". The cause of the issue is that the regexp failed to match the file because '/' is not present in the pattern. A solution to the problem would had been to add the / (and \ for Windows) to the pattern, but removing "file: " from "file:/path/file.py" is simpler.
Contributor
|
Here's the code health analysis summary for commits Analysis Summary
|
Author
|
First time contributing, I tried to look for unittests but it seems there are none. Also it seems to me that deepsource-io is complaining about a problem that is unrelated to this work. |
Author
|
Btw, here is the complete traceback and steps to reproduce the problem: |
Author
|
And then the result on my branch: |
Owner
|
Thanks, you did a great job. Seems good, will merge in the morning. Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When --setup is given a file which is not in the current directory, it fails with an attribute error "None has no attribute group". The cause of the issue is that the regexp failed to match the file because '/' is not present in the pattern.
A solution to the problem would had been to add the / (and \ for Windows) to the pattern, but removing "file: " from "file:/path/file.py" is simpler.