Skip to content

Fix security eui memory table warnings #6707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 28, 2024
Merged

Fix security eui memory table warnings #6707

merged 3 commits into from
May 28, 2024

Conversation

JuanGarriuz
Copy link
Contributor

Description

This PR fixes the console warning related to invalid props supplied to EuiInMemoryTable

Issues Resolved

Evidence

image
image

Test

  • Go to Server management > Security
  • Change between Roles and Policies tabs
  • This console warning mustn't be rendered

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@JuanGarriuz JuanGarriuz changed the base branch from master to 4.9.0 May 24, 2024 10:46
@JuanGarriuz JuanGarriuz self-assigned this May 24, 2024
@JuanGarriuz JuanGarriuz linked an issue May 24, 2024 that may be closed by this pull request
Warnings and errors in console #6693
Closed
15 tasks
@JuanGarriuz JuanGarriuz mentioned this pull request May 24, 2024
Closed
15 tasks
asteriscos
asteriscos approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

Peek 2024-05-27 18-09

yenienserrano
yenienserrano approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Screen.Recording.2024-05-27.at.8.13.15.PM.mov

@asteriscos asteriscos merged commit 6aba5cc into 4.9.0 May 28, 2024
1 check passed
@asteriscos asteriscos deleted the fix/6693-security-eui-memory-table-warnings branch May 28, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@yenienserrano yenienserrano yenienserrano approved these changes

Assignees

@JuanGarriuz JuanGarriuz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warnings and errors in console
3 participants
@JuanGarriuz @asteriscos @yenienserrano