Skip to content

Fix warning type error in status view #6722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2024

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented May 29, 2024

Description

Removes an error in the console when navigating to Status with a manager without the cluster enabled or when switching from a manager with the cluster enabled to a manager without the cluster enabled in the Status view.

Issues Resolved

Evidence

Screen.Recording.2024-05-29.at.8.48.10.PM.mov

Test

  1. Navigate to Server Management > Status
  2. Check that the error does not appear in the console
    Failed prop type: Invalid prop value supplied to EuiSelect, expected one of type [string, number]
  3. Change manager with cluster enable to manager with cluster disabled
  4. Check that the error does not appear in the console
    Failed prop type: Invalid prop value supplied to EuiSelect, expected one of type [string, number]

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this May 29, 2024
@yenienserrano yenienserrano changed the title Conditional render Fix warning type error in status view May 29, 2024
@yenienserrano yenienserrano linked an issue May 29, 2024 that may be closed by this pull request
15 tasks
@yenienserrano yenienserrano mentioned this pull request May 29, 2024
15 tasks
Copy link
Contributor

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢

Test 🟢

screen-capture.webm

@asteriscos asteriscos self-requested a review May 30, 2024 11:46
@chantal-kelm chantal-kelm self-requested a review May 30, 2024 15:28
Copy link
Contributor

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Grabacion.de.pantalla.2024-05-30.a.la.s.12.33.26.p.m.mov

@asteriscos asteriscos merged commit d2543a7 into 4.9.0 May 30, 2024
1 check passed
@asteriscos asteriscos deleted the fix/6693-Invalid-prop-value-supplied-to-EuiSelect branch May 30, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings and errors in console
4 participants