Skip to content

Commit bf543ec

Browse files
authored
fix(sdk): saveManifest need await when brief mode (#498)
1 parent 5b5a67c commit bf543ec

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

.changeset/stupid-comics-mate.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@rsdoctor/webpack-plugin': patch
3+
'@rsdoctor/sdk': patch
4+
---
5+
6+
fix(sdk): saveManifest need await when brief mode

packages/sdk/src/sdk/sdk/webpack.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -373,15 +373,15 @@ export class RsdoctorWebpackSDK<
373373
}
374374
}
375375

376-
public writeStore(options?: SDK.WriteStoreOptionsType) {
376+
public async writeStore(options?: SDK.WriteStoreOptionsType) {
377377
debug(() => `sdk.writeStore has run.`, '[SDK.writeStore][end]');
378378
if (this.extraConfig?.mode === SDK.IMode[SDK.IMode.brief]) {
379379
const clientHtmlPath = this.extraConfig.innerClientPath
380380
? this.extraConfig.innerClientPath
381381
: require.resolve('@rsdoctor/client');
382382

383383
if (this.extraConfig.brief?.writeDataJson) {
384-
this.saveManifest(this.getStoreData(), options || {});
384+
await this.saveManifest(this.getStoreData(), options || {});
385385
}
386386
return this.inlineScriptsAndStyles(clientHtmlPath);
387387
}

packages/webpack-plugin/src/plugin.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,8 @@ export class RsdoctorWebpackPlugin<Rules extends Linter.ExtendRuleData[]>
214214
);
215215
openBrowser(`file:///${outputFilePath}`);
216216
}
217-
} catch (e) {}
217+
} catch (e) {
218+
console.error(`[Rsdoctor] Webpack plugin this.done error`, e);
219+
}
218220
};
219221
}

0 commit comments

Comments
 (0)