Skip to content

Commit f0ccc86

Browse files
authored
Fix(ui): The file tree elements have problems with keyword searches. (#767)
1 parent ec52ef5 commit f0ccc86

File tree

4 files changed

+13
-15
lines changed

4 files changed

+13
-15
lines changed

packages/components/src/components/Loader/Analysis/files.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -105,10 +105,7 @@ export const LoaderFiles: React.FC<{
105105
}}
106106
>
107107
<div className={styles.keywords}>
108-
<Keyword
109-
text={basename.replace(/\[.*?\]/g, '')}
110-
keyword={props.filename}
111-
/>
108+
<Keyword text={basename.replace(/\[.*?\]/g, '')} keyword={''} />
112109
</div>
113110
<div className={styles.dividerDiv}>
114111
<Divider className={styles.divider} dashed />
@@ -209,7 +206,7 @@ export const LoaderFiles: React.FC<{
209206
);
210207
},
211208
dirTitle(_dir, defaultTitle) {
212-
return <Keyword text={defaultTitle} keyword={props.filename} />;
209+
return <Keyword text={defaultTitle} keyword={''} />;
213210
},
214211
});
215212
}, [filteredFiles]);

packages/components/src/pages/BundleSize/components/asset.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@ export const AssetDetail: React.FC<{
396396
<div className={styles['bundle-tree']}>
397397
<div className={styles.box}>
398398
<div className={styles.keywords}>
399-
<Keyword ellipsis text={basename} keyword={moduleKeyword} />
399+
<Keyword ellipsis text={basename} keyword={''} />
400400
</div>
401401

402402
<div className={styles.dividerDiv}>
@@ -563,7 +563,7 @@ export const AssetDetail: React.FC<{
563563
<Card
564564
className={styles.bundle}
565565
title={`Modules of "${asset.path}"`}
566-
bodyStyle={{ overflow: 'scroll', height }}
566+
bodyStyle={{ minHeight: height }}
567567
size="small"
568568
>
569569
{includeModules.length ? (
@@ -610,7 +610,8 @@ export const AssetDetail: React.FC<{
610610
}
611611
treeData={fileStructures as AntdDataNode[]}
612612
rootStyle={{
613-
minHeight: '800px',
613+
maxHeight: '500px',
614+
overflow: 'auto',
614615
border: '1px solid rgba(235, 237, 241)',
615616
padding: '14px 20px',
616617
}}

packages/components/src/pages/BundleSize/components/index.tsx

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ import { GraphType } from '../constants';
3838

3939
const { Option } = Select;
4040

41-
const cardBodyHeight = 410;
41+
const cardBodyHeight = 600;
4242

4343
const largeCardBodyHeight = 800;
4444

@@ -241,11 +241,7 @@ export const WebpackModulesOverallBase: React.FC<
241241
setAssetPath(path);
242242
}}
243243
>
244-
<Keyword
245-
text={basename}
246-
keyword={inputAssetName}
247-
className={styles.fileText}
248-
/>
244+
<Keyword text={basename} keyword={''} className={styles.fileText} />
249245
<Space size="small" className={styles.assetsTag}>
250246
<Divider type="vertical" />
251247
<Typography.Text style={{ color: '#4FD233' }}>

packages/core/src/rules/rules/duplicate-package/index.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,11 @@ export const rule = defineRule<typeof title, Config>(() => ({
4141
gt(_packA.version, _packB.version) ? 1 : -1,
4242
);
4343
})
44-
.filter((pkgs) => pkgs.length > 1);
44+
.filter(
45+
(pkgs) =>
46+
pkgs.length > 1 &&
47+
pkgs.filter((pkg) => pkg.getSize().parsedSize > 0).length > 1,
48+
);
4549

4650
for (const pkg of packages) {
4751
const message = getErrorMsg(pkg, root);

0 commit comments

Comments
 (0)