Skip to content

Commit 4a204e6

Browse files
committed
updates from rfc discussion
1 parent 176ebc4 commit 4a204e6

File tree

5 files changed

+32
-13
lines changed

5 files changed

+32
-13
lines changed

.github/workflows/update-test262-tests.yml

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,19 @@ jobs:
2121
path: test262-spec
2222
- name: Copy Test262 tests to WPT
2323
run: |
24-
rsync -a --delete test262-spec/test/ wpt/tc39/test262/test/
25-
rsync -a --delete test262-spec/harness/ wpt/tc39/test262/harness/
24+
LATEST_SHA=$(git -C test262-spec rev-parse HEAD)
25+
echo "Latest remote Test262 SHA: $LATEST_SHA"
26+
27+
mkdir -p wpt/third_party/test262/test/
28+
mkdir -p wpt/third_party/test262/harness/
29+
rsync -a --delete test262-spec/test/ wpt/third_party/test262/test/
30+
rsync -a --delete test262-spec/harness/ wpt/third_party/test262/harness/
31+
cat <<EOF > wpt/third_party/test262/vendored.toml
32+
[test262]
33+
source = "https://github.com/tc39/test262"
34+
rev = "${LATEST_SHA}"
35+
EOF
36+
2637
- name: Commit changes
2738
id: commit
2839
continue-on-error: true
@@ -32,8 +43,8 @@ jobs:
3243
echo "BRANCH_NAME=$BRANCH_NAME" >> $GITHUB_ENV
3344
git config user.name "$GIT_AUTHOR_NAME"
3445
git config user.email "$GIT_AUTHOR_EMAIL"
35-
git checkout -b $BRANCH_NAME
36-
git add tc39/test262/
46+
git checkout -B $BRANCH_NAME
47+
git add third_party/test262/
3748
git commit -m "$COMMIT_TITLE"
3849
env:
3950
GIT_AUTHOR_NAME: "wpt-pr-bot"

lint.ignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -839,4 +839,4 @@ PROMISE_REJECTS: wasm/core/js/harness/testharness.js
839839
# Legitimate use of test_driver_internal
840840
TEST DRIVER INTERNAL: resources/testdriver.js
841841

842-
*: tc39/*
842+
*: third_party/test262/*

tools/ci/tc/tasks/test.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,12 @@ components:
4141
vars:
4242
test-type: crashtest
4343

44+
wpt-test262:
45+
chunks: 16
46+
vars:
47+
test-type: test262
48+
49+
4450
run-options:
4551
options:
4652
xvfb: true
@@ -159,6 +165,8 @@ tasks:
159165
suite: wdspec
160166
- vars:
161167
suite: crashtest
168+
- vars:
169+
suite: test262
162170
do:
163171
$map:
164172
for:

tools/serve/serve.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
from localpaths import repo_root # type: ignore
2525

2626
from manifest.sourcefile import read_script_metadata, js_meta_re, parse_variants # type: ignore
27-
from manifest.test262 import TestRecord
27+
from manifest.test262 import TestRecord # type: ignore
2828
from wptserve import server as wptserve, handlers
2929
from wptserve import stash
3030
from wptserve import config
@@ -352,8 +352,8 @@ class Test262WindowTestHandler(HtmlWrapperHandler):
352352
<meta charset=utf-8>
353353
<title>%(path)s</title>
354354
<script src="/resources/test262/testharness-client.js"></script>
355-
<script src="/tc39/test262/harness/assert.js"></script>
356-
<script src="/tc39/test262/harness/sta.js"></script>
355+
<script src="/third_party/test262/harness/assert.js"></script>
356+
<script src="/third_party/test262/harness/sta.js"></script>
357357
<script src="/resources/test262/harness-adapter.js"></script>
358358
%(meta)s
359359
%(script)s"""
@@ -365,7 +365,7 @@ def _get_metadata(self, request):
365365
path = self._get_filesystem_path(request)
366366
with open(path, encoding='ISO-8859-1') as f:
367367
test_record = TestRecord.parse(f.read(), path)
368-
yield from (('script', "/tc39/test262/harness/%s" % filename)
368+
yield from (('script', "/third_party/test262/harness/%s" % filename)
369369
for filename in test_record.get("includes", []))
370370
expected_error = test_record.get('negative', {}).get('type', None)
371371
if expected_error is not None:

tools/serve/test_serve.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -223,8 +223,8 @@ def test_test262_window_test_handler_get_metadata_includes(test262_handlers: Any
223223
handler = Test262WindowTestHandler(base_path=tests_root, url_base=url_base)
224224
mock_request = _create_mock_request("/test262/basic.test262-test.html")
225225
metadata = list(handler._get_metadata(mock_request))
226-
assert ('script', '/tc39/test262/harness/assert.js') in metadata
227-
assert ('script', '/tc39/test262/harness/sta.js') in metadata
226+
assert ('script', '/third_party/test262/harness/assert.js') in metadata
227+
assert ('script', '/third_party/test262/harness/sta.js') in metadata
228228

229229

230230
def test_test262_window_test_handler_get_metadata_negative(test262_handlers: Any) -> None:
@@ -245,8 +245,8 @@ def test_test262_window_test_handler_wrapper_content(test262_handlers: Any) -> N
245245
handler.handle_request(mock_request, mock_response)
246246
content = mock_response.content
247247
assert "<script src=\"/resources/test262/testharness-client.js\"></script>" in content
248-
assert "<script src=\"/tc39/test262/harness/assert.js\"></script>" in content
249-
assert "<script src=\"/tc39/test262/harness/sta.js\"></script>" in content
248+
assert "<script src=\"/third_party/test262/harness/assert.js\"></script>" in content
249+
assert "<script src=\"/third_party/test262/harness/sta.js\"></script>" in content
250250
assert "<script>test262Setup()</script>" in content
251251
assert "<script src=\"/test262/basic.js\"></script>" in content
252252
assert "<script>test262Done()</script>" in content

0 commit comments

Comments
 (0)