Remove dependency to the Scroll Anchoring in scroll behavior tests of… #55051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Navigation API web-platform-tests#55050 Following tests depend on Scroll Anchoring behavior after removing the div. The scroll position is asserted but they are different whether Scroll Anchoring is on or off. - navigation-api/scroll-behavior/after-transition-reload.html - navigation-api/scroll-behavior/manual-scroll-reload.html In this PR, that assertion is removed.
|
Isn't scroll anchoring an expected part of the web platform these days? I think this tests behavior that web developers probably depend on and expect, so removing coverage seems bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Navigation API
#55050
Following tests depend on Scroll Anchoring behavior after removing the div. The scroll position is asserted but they are different whether Scroll Anchoring is on or off.
In this PR, that assertion is removed.