Make dropEffect and effectAllowed blink web tests a WPT test #55087
+560
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL makes the `fast/events/drag-and-drop.html` web test into a WPT test that uses the action driver API. The new tests verify that dragging with different `effectAllowed`s result in the correct behavior when dropping onto different `dropEffect`s. Each file tests all of the effectAllowed divs against one dropEffect. I originally intended to cross all effectAllowed divs against all dropEffect divs in one single file, but the test ran for too long and timed out before it could be finished. There are five tests that verify that the values are properly set on the drop event (sent to the drop target), and five similar tests that verify that the values are properly set on the dragEnd event (sent to the drag div). Bug: 434151262, 441537624 Change-Id: Iffd1788508a847c6b928c50fc3f44ebce147c4f9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL makes the
fast/events/drag-and-drop.htmlweb test into a WPTtest that uses the action driver API.
The new tests verify that dragging with different
effectAllowedsresult in the correct behavior when dropping onto different
dropEffects.Each file tests all of the effectAllowed divs against one dropEffect. I
originally intended to cross all effectAllowed divs against all
dropEffect divs in one single file, but the test ran for too long and
timed out before it could be finished.
There are five tests that verify that the values are properly set on the
drop event (sent to the drop target), and five similar tests that verify
that the values are properly set on the dragEnd event (sent to the drag
div).
Bug: 434151262, 441537624
Change-Id: Iffd1788508a847c6b928c50fc3f44ebce147c4f9
Reviewed-on: https://chromium-review.googlesource.com/6956095
WPT-Export-Revision: 4ed7f3daa235f7b13d7b183f17c971a876d8c5ac