Add a test for CustomElementRegistry.initialize upgrading custom elements per https://github.com/whatwg/html/pull/11913. #56034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
TakayoshiKochi,
hayatoito,
kojiishi and
snuggs
rniwa
requested review from
mfreed7 and
smaug----
and removed request for
TakayoshiKochi,
hayatoito,
kojiishi and
snuggs
annevk
approved these changes
Nov 18, 2025
Member
annevk
left a comment
annevk
left a comment
There was a problem hiding this comment.
Looks good, but console.log issue needs to be addressed.
| <body> | ||
| <script> | ||
|
|
||
| function runTest(title, makeDocument, makeCustomElementRegistry) { |
Member
There was a problem hiding this comment.
Nit: we don't need makeCustomElementRegistry it seems as it's always the same.
|
|
||
| const registry2 = makeCustomElementRegistry(); | ||
| undefinedElement2 = doc1.createElementNS(htmlNS, 'a-b', {customElementRegistry: registry2}); | ||
| console.log(undefinedElement2); |
6 tasks
rniwa
force-pushed
the
add-scoped-custom-element-registry-initialize-upgrade-test
branch
from
8c2b5ba to
10333de
Compare
rniwa
deleted the
add-scoped-custom-element-registry-initialize-upgrade-test
branch
ja-y-son
reviewed
Nov 19, 2025
| registry.define('a-b', class ABElement extends HTMLElement { }); | ||
| assert_equals(element.customElementRegistry, null); | ||
| registry.initialize(element); | ||
| assert_equals(element.customElementRegistry, registry); |
Contributor
There was a problem hiding this comment.
Do we also want to assert that element is an instance of ABElement here?
Contributor
|
Like mentioned in whatwg/html#11913 (comment), we probably want to add a test to verify that the descendant with the same registry also gets upgraded in the initialize call. |
annevk
added a commit
to whatwg/html
that referenced
this pull request
Nov 21, 2025
CustomElementRegistry's upgrade() wasn't adjusted for scoped registries and we decided that initialize() should upgrade as well (but not into shadow trees as upgrade() does). The initialize() design here favors a single tree traversal for setting the registry and then upgrading the element. Tests: - web-platform-tests/wpt#56034 - web-platform-tests/wpt#56132 Fixes #11858 and fixes #11908.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.