Support multiple instances #889
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Resolves #876
Implementation
gcmAPIKeyandvapidDetailsinsrc/web-push-lib.js, we change those to instance properties of aWebPushLibclass instance.setGCMAPIKey,setVapidDetails,generateRequestDetailsfor the global instance ofWebPushLib, we need to.bind()the methods to retain thethiscontext.WebPushLibconstructor so users can create multiple instances instead of just using the global instance.