Skip to content

Time input overflowing fix #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Time input overflowing fix #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6bdbbb
time input overflowing fix
May 5, 2025
3092a32
added padding left to the input box according to the platform device
May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Time/TimeInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@
: undefined,
borderWidth: theme.isV3 && highlighted ? 2 : 0,
height: inputType === inputTypes.keyboard ? 72 : 80,
paddingLeft: (Platform.OS === 'android' || Platform.OS === 'ios') ? 0 : 10,

Check failure on line 86 in src/Time/TimeInput.tsx

View workflow job for this annotation

GitHub Actions / lint 

Replace `·(Platform.OS·===·'android'·||·Platform.OS·===·'ios')` with `⏎············Platform.OS·===·'android'·||·Platform.OS·===·'ios'`
},
]}
>
Expand Down Expand Up @@ -143,8 +144,7 @@

const styles = StyleSheet.create({
root: {
alignItems: 'center',
justifyContent: 'center',
justifyContent: "center",

Check failure on line 147 in src/Time/TimeInput.tsx

View workflow job for this annotation

GitHub Actions / lint 

Replace `"center"` with `'center'`
width: 96,
},
input: {
Expand Down
2 changes: 1 addition & 1 deletion src/__tests__/Time/__snapshots__/TimeInput.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ exports[`renders TimeInput 1`] = `
style={
[
{
"alignItems": "center",
"justifyContent": "center",
"width": 96,
},
Expand All @@ -15,6 +14,7 @@ exports[`renders TimeInput 1`] = `
"borderRadius": 8,
"borderWidth": 2,
"height": 80,
"paddingLeft": 0,
},
]
}
Expand Down
4 changes: 2 additions & 2 deletions src/__tests__/Time/__snapshots__/TimeInputs.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ exports[`renders TimeInputs 1`] = `
style={
[
{
"alignItems": "center",
"justifyContent": "center",
"width": 96,
},
Expand All @@ -33,6 +32,7 @@ exports[`renders TimeInputs 1`] = `
"borderRadius": 8,
"borderWidth": 0,
"height": 72,
"paddingLeft": 0,
},
]
}
Expand Down Expand Up @@ -172,7 +172,6 @@ exports[`renders TimeInputs 1`] = `
style={
[
{
"alignItems": "center",
"justifyContent": "center",
"width": 96,
},
Expand All @@ -182,6 +181,7 @@ exports[`renders TimeInputs 1`] = `
"borderRadius": 8,
"borderWidth": 0,
"height": 72,
"paddingLeft": 0,
},
]
}
Expand Down
4 changes: 2 additions & 2 deletions src/__tests__/Time/__snapshots__/TimePicker.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ exports[`renders TimePicker 1`] = `
style={
[
{
"alignItems": "center",
"justifyContent": "center",
"width": 96,
},
Expand All @@ -41,6 +40,7 @@ exports[`renders TimePicker 1`] = `
"borderRadius": 8,
"borderWidth": 0,
"height": 72,
"paddingLeft": 0,
},
]
}
Expand Down Expand Up @@ -180,7 +180,6 @@ exports[`renders TimePicker 1`] = `
style={
[
{
"alignItems": "center",
"justifyContent": "center",
"width": 96,
},
Expand All @@ -190,6 +189,7 @@ exports[`renders TimePicker 1`] = `
"borderRadius": 8,
"borderWidth": 0,
"height": 72,
"paddingLeft": 0,
},
]
}
Expand Down
Loading